Don't change the case of cookie names and values

tests/standalone/io/http_headers_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 import 'dart:async';
 import 'dart:math';
 
 part "../../../sdk/lib/io/io_sink.dart";
 part "../../../sdk/lib/io/http.dart";
@@ skipping 296 matching lines @@
   Expect.equals("text/html", headers.contentType.value);
   headers.set(HttpHeaders.CONTENT_TYPE, "text/plain; charset=utf-8");
   Expect.equals("text", headers.contentType.primaryType);
   Expect.equals("plain", headers.contentType.subType);
   Expect.equals("text/plain", headers.contentType.value);
   headers.removeAll(HttpHeaders.CONTENT_TYPE);
   Expect.isNull(headers.contentType);
 }
 
 void testCookie() {
-  void checkCookiesEquals(a, b) {
-    Expect.equals(a.name, b.name);
-    Expect.equals(a.value, b.value);
-    Expect.equals(a.expires, b.expires);
-    Expect.equals(a.toString(), b.toString());
+  test(String name, String value) {
+
+    void checkCookiesEquals(a, b) {
+      Expect.equals(a.name, b.name);
+      Expect.equals(a.value, b.value);
+      Expect.equals(a.expires, b.expires);
+      Expect.equals(a.toString(), b.toString());
+    }
+
+    void checkCookie(cookie, s) {
+      Expect.equals(s, cookie.toString());
+      var c = new _Cookie.fromSetCookieValue(s);
+      checkCookiesEquals(cookie, c);
+    }
+
+    Cookie cookie;
+    cookie = new Cookie(name, value);
+    Expect.equals("$name=$value", cookie.toString());
+    DateTime date = new DateTime.utc(2014, DateTime.JANUARY, 5, 23, 59, 59, 0);
+    cookie.expires = date;
+    checkCookie(cookie, "$name=$value"
+                "; Expires=Sun, 5 Jan 2014 23:59:59 GMT");
+    cookie.maxAge = 567;
+    checkCookie(cookie, "$name=$value"
+                "; Expires=Sun, 5 Jan 2014 23:59:59 GMT"
+                "; Max-Age=567");
+    cookie.domain = "example.com";
+    checkCookie(cookie, "$name=$value"
+                "; Expires=Sun, 5 Jan 2014 23:59:59 GMT"
+                "; Max-Age=567"
+                "; Domain=example.com");
+    cookie.path = "/xxx";
+    checkCookie(cookie, "$name=$value"
+                "; Expires=Sun, 5 Jan 2014 23:59:59 GMT"
+                "; Max-Age=567"
+                "; Domain=example.com"
+                "; Path=/xxx");
+    cookie.secure = true;
+    checkCookie(cookie, "$name=$value"
+                "; Expires=Sun, 5 Jan 2014 23:59:59 GMT"
+                "; Max-Age=567"
+                "; Domain=example.com"
+                "; Path=/xxx"
+                "; Secure");
+    cookie.httpOnly = true;
+    checkCookie(cookie, "$name=$value"
+                "; Expires=Sun, 5 Jan 2014 23:59:59 GMT"
+                "; Max-Age=567"
+                "; Domain=example.com"
+                "; Path=/xxx"
+                "; Secure"
+                "; HttpOnly");
+    cookie.expires = null;
+    checkCookie(cookie, "$name=$value"
+                "; Max-Age=567"
+                "; Domain=example.com"
+                "; Path=/xxx"
+                "; Secure"
+                "; HttpOnly");
+    cookie.maxAge = null;
+    checkCookie(cookie, "$name=$value"
+                "; Domain=example.com"
+                "; Path=/xxx"
+                "; Secure"
+                "; HttpOnly");
+    cookie.domain = null;
+    checkCookie(cookie, "$name=$value"
+                "; Path=/xxx"
+                "; Secure"
+                "; HttpOnly");
+    cookie.path = null;
+    checkCookie(cookie, "$name=$value"
+                "; Secure"
+                "; HttpOnly");
+    cookie.secure = false;
+    checkCookie(cookie, "$name=$value"
+                "; HttpOnly");
+    cookie.httpOnly = false;
+    checkCookie(cookie, "$name=$value");
   }
-
-  void checkCookie(cookie, s) {
-    Expect.equals(s, cookie.toString());
-    var c = new _Cookie.fromSetCookieValue(s);
-    checkCookiesEquals(cookie, c);
-  }
-
-  Cookie cookie;
-  cookie = new Cookie("name", "value");
-  Expect.equals("name=value", cookie.toString());
-  DateTime date = new DateTime.utc(2014, DateTime.JANUARY, 5, 23, 59, 59, 0);
-  cookie.expires = date;
-  checkCookie(cookie, "name=value"
-                      "; Expires=Sun, 5 Jan 2014 23:59:59 GMT");
-  cookie.maxAge = 567;
-  checkCookie(cookie, "name=value"
-                      "; Expires=Sun, 5 Jan 2014 23:59:59 GMT"
-                      "; Max-Age=567");
-  cookie.domain = "example.com";
-  checkCookie(cookie, "name=value"
-                      "; Expires=Sun, 5 Jan 2014 23:59:59 GMT"
-                      "; Max-Age=567"
-                      "; Domain=example.com");
-  cookie.path = "/xxx";
-  checkCookie(cookie, "name=value"
-                      "; Expires=Sun, 5 Jan 2014 23:59:59 GMT"
-                      "; Max-Age=567"
-                      "; Domain=example.com"
-                      "; Path=/xxx");
-  cookie.secure = true;
-  checkCookie(cookie, "name=value"
-                      "; Expires=Sun, 5 Jan 2014 23:59:59 GMT"
-                      "; Max-Age=567"
-                      "; Domain=example.com"
-                      "; Path=/xxx"
-                      "; Secure");
-  cookie.httpOnly = true;
-  checkCookie(cookie, "name=value"
-                      "; Expires=Sun, 5 Jan 2014 23:59:59 GMT"
-                      "; Max-Age=567"
-                      "; Domain=example.com"
-                      "; Path=/xxx"
-                      "; Secure"
-                      "; HttpOnly");
-  cookie.expires = null;
-  checkCookie(cookie, "name=value"
-                      "; Max-Age=567"
-                      "; Domain=example.com"
-                      "; Path=/xxx"
-                      "; Secure"
-                      "; HttpOnly");
-  cookie.maxAge = null;
-  checkCookie(cookie, "name=value"
-                      "; Domain=example.com"
-                      "; Path=/xxx"
-                      "; Secure"
-                      "; HttpOnly");
-  cookie.domain = null;
-  checkCookie(cookie, "name=value"
-                      "; Path=/xxx"
-                      "; Secure"
-                      "; HttpOnly");
-  cookie.path = null;
-  checkCookie(cookie, "name=value"
-                      "; Secure"
-                      "; HttpOnly");
-  cookie.secure = false;
-  checkCookie(cookie, "name=value"
-                      "; HttpOnly");
-  cookie.httpOnly = false;
-  checkCookie(cookie, "name=value");
+  test("name", "value");
+  test("abc", "def");
+  test("ABC", "DEF");
+  test("Abc", "Def");
+  test("SID", "sJdkjKSJD12343kjKj78");

[Bill Hesse, 2013/06/04 08:30:14]

While you are at it, are there any non-ascii values you can test, or are they
not valid?  Or are they tested elsewhere?

[Søren Gjesse, 2013/06/04 08:54:45]

We are definitely not trying to parse according to the spec which says:

 cookie-pair       = cookie-name "=" cookie-value
 cookie-name       = token
 cookie-value      = *cookie-octet / ( DQUOTE *cookie-octet DQUOTE )
 cookie-octet      = %x21 / %x23-2B / %x2D-3A / %x3C-5B / %x5D-7E
                       ; US-ASCII characters excluding CTLs,
                       ; whitespace DQUOTE, comma, semicolon,
                       ; and backslash

I will make a separate CL for this.

 }
 
 void testInvalidCookie() {
   Expect.throws(() => new _Cookie.fromSetCookieValue(""));
   Expect.throws(() => new _Cookie.fromSetCookieValue("="));
   Expect.throws(() => new _Cookie.fromSetCookieValue("=xxx"));
   Expect.throws(() => new _Cookie.fromSetCookieValue("xxx"));
   Expect.throws(() => new _Cookie.fromSetCookieValue("xxx=yyy; expires=12 jan 2013"));
 }
 
@@ skipping 11 matching lines @@
   testIfModifiedSince();
   testHost();
   testEnumeration();
   testHeaderValue();
   testContentType();
   testContentTypeCache();
   testCookie();
   testInvalidCookie();
   testHeaderLists();
 }