Issue 16231012: Cover the 'extends' and typedef cases of the CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE e…

Issue 16231012: Cover the 'extends' and typedef cases of the CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE e… (Closed)

Created:
7 years, 6 months ago by jwren

Modified:
7 years, 6 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cover the 'extends' and typedef cases of the CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE error code. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=23473

Patch Set 2 : Rebase with bleeding_edge #

Total comments: 2

Patch Set 4 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -55 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1	2 chunks	+29 lines, -12 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	8 chunks	+37 lines, -13 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/index/IndexContributorTest.java	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1 2 3	5 chunks	+59 lines, -10 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 2 3	2 chunks	+0 lines, -10 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

scheglov

lgtm https://codereview.chromium.org/16231012/diff/3001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java (right): https://codereview.chromium.org/16231012/diff/3001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java#newcode1738 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java:1738: assertErrors(CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE_BASE_CASE_IMPLEMENTS); Hm... It generates the error, why is ...

7 years, 6 months ago (2013-05-30 23:12:40 UTC) #3

jwren

https://codereview.chromium.org/16231012/diff/3001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java (right): https://codereview.chromium.org/16231012/diff/3001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java#newcode1738 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java:1738: assertErrors(CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE_BASE_CASE_IMPLEMENTS); Before the rename from IMPLEMENTS_SELF, it was more ...

7 years, 6 months ago (2013-05-31 16:00:33 UTC) #5

jwren

7 years, 6 months ago (2013-05-31 16:20:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r23473 (presubmit successful).

Expand Messages | Collapse Messages