Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java

Issue 16231012: Cover the 'extends' and typedef cases of the CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE e… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
index a068c88164a408bd1de82936451a9f800b290dbc..70aa4201d6f96bdb9c0d80daf1db14cf294e3948 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
@@ -480,17 +480,6 @@ public enum CompileTimeErrorCode implements ErrorCode {
IMPLEMENTS_REPEATED("'%s' can only be implemented once"),
/**
- * 7.10 Superinterfaces: It is a compile-time error if the interface of a class <i>C</i> is a
- * superinterface of itself.
- * <p>
- * Note: this error code is a subset of the {@link #RECURSIVE_INTERFACE_INHERITANCE} error code.
- *
- * @param className the name of the class that implements itself
- * @see #RECURSIVE_INTERFACE_INHERITANCE
- */
- IMPLEMENTS_SELF("'%s' cannot implement itself"),
-
- /**
* 7.6.1 Generative Constructors: Note that this is not in scope on the right hand side of an
* initializer.
* <p>
@@ -905,15 +894,43 @@ public enum CompileTimeErrorCode implements ErrorCode {
RECURSIVE_FUNCTION_TYPE_ALIAS(""),
/**
+ * 7.10 Superinterfaces: It is a compile-time error if the interface of a class <i>C</i> is a
+ * superinterface of itself.
+ * <p>
* 8.1 Superinterfaces: It is a compile-time error if an interface is a superinterface of itself.
+ * <p>
+ * 7.9 Superclasses: It is a compile-time error if a class <i>C</i> is a superclass of itself.
*
* @param className the name of the class that implements itself recursively
* @param strImplementsPath a string representation of the implements loop
- * @see #IMPLEMENTS_SELF
*/
RECURSIVE_INTERFACE_INHERITANCE("'%s' cannot be a superinterface of itself: %s"),
/**
+ * 7.10 Superinterfaces: It is a compile-time error if the interface of a class <i>C</i> is a
+ * superinterface of itself.
+ * <p>
+ * 8.1 Superinterfaces: It is a compile-time error if an interface is a superinterface of itself.
+ * <p>
+ * 7.9 Superclasses: It is a compile-time error if a class <i>C</i> is a superclass of itself.
+ *
+ * @param className the name of the class that implements itself recursively
+ */
+ RECURSIVE_INTERFACE_INHERITANCE_BASE_CASE_EXTENDS("'%s' cannot extend itself"),
+
+ /**
+ * 7.10 Superinterfaces: It is a compile-time error if the interface of a class <i>C</i> is a
+ * superinterface of itself.
+ * <p>
+ * 8.1 Superinterfaces: It is a compile-time error if an interface is a superinterface of itself.
+ * <p>
+ * 7.9 Superclasses: It is a compile-time error if a class <i>C</i> is a superclass of itself.
+ *
+ * @param className the name of the class that implements itself recursively
+ */
+ RECURSIVE_INTERFACE_INHERITANCE_BASE_CASE_IMPLEMENTS("'%s' cannot implement itself"),
+
+ /**
* 7.6.2 Factories: It is a compile-time error if <i>k</i> is prefixed with the const modifier but
* <i>k'</i> is not a constant constructor.
*/
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698