Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 16231008: Remove unused (and little used) cli flags from dartanalyzer. (Closed)

Created:
7 years, 6 months ago by devoncarew
Modified:
7 years, 6 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove unused (and little used) cli flags from dartanalyzer. R=danrubel@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=23441

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Messages

Total messages: 5 (0 generated)
devoncarew
7 years, 6 months ago (2013-05-30 20:32:10 UTC) #1
scheglov
LGTM https://codereview.chromium.org/16231008/diff/4001/pkg/analyzer_experimental/lib/options.dart File pkg/analyzer_experimental/lib/options.dart (right): https://codereview.chromium.org/16231008/diff/4001/pkg/analyzer_experimental/lib/options.dart#newcode157 pkg/analyzer_experimental/lib/options.dart:157: // This happens when the script is not ...
7 years, 6 months ago (2013-05-30 20:36:03 UTC) #2
devoncarew
https://codereview.chromium.org/16231008/diff/4001/pkg/analyzer_experimental/lib/options.dart File pkg/analyzer_experimental/lib/options.dart (right): https://codereview.chromium.org/16231008/diff/4001/pkg/analyzer_experimental/lib/options.dart#newcode157 pkg/analyzer_experimental/lib/options.dart:157: // This happens when the script is not running ...
7 years, 6 months ago (2013-05-30 20:42:19 UTC) #3
danrubel
lgtm
7 years, 6 months ago (2013-05-30 21:04:04 UTC) #4
devoncarew
7 years, 6 months ago (2013-05-30 21:06:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r23441 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698