Remove unused (and little used) cli flags from dartanalyzer.

pkg/analyzer_experimental/lib/options.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library options;
 
 import 'package:args/args.dart';
 
 import 'dart:io';
 
 
-const _BINARY_NAME = 'analyzer';
+const _BINARY_NAME = 'dartanalyzer';
 
 /**
  * Analyzer commandline configuration options.
  */
 class CommandLineOptions {
 
   /** Batch mode (for unit testing) */
   final bool shouldBatch;
 
   /** Whether to use machine format for error display */
   final bool machineFormat;
 
+  /** Whether to display version information */
+  final bool displayVersion;
+
   /** Whether to ignore unrecognized flags */
   final bool ignoreUnrecognizedFlags;
 
   /** Whether to show package: warnings */
   final bool showPackageWarnings;
 
   /** Whether to show SDK warnings */
   final bool showSdkWarnings;
 
   /** Whether to treat warnings as fatal */
   final bool warningsAreFatal;
 
   /** The path to the dart SDK */
   final String dartSdkPath;
 
   /** The path to the package root */
   final String packageRootPath;
 
   /** The source files to analyze */
   final List<String> sourceFiles;
 
   /**
    * Initialize options from the given parsed [args].
    */
   CommandLineOptions._fromArgs(ArgResults args)
     : shouldBatch = args['batch'],
-      machineFormat = args['machine-format'],
+      machineFormat = args['machine'],
+      displayVersion = args['version'],
       ignoreUnrecognizedFlags = args['ignore-unrecognized-flags'],
       showPackageWarnings = args['show-package-warnings'],
       showSdkWarnings = args['show-sdk-warnings'],
       warningsAreFatal = args['fatal-warnings'],
       dartSdkPath = args['dart-sdk'],
       packageRootPath = args['package-root'],
       sourceFiles = args.rest;
 
   /**
    * Parse [args] into [CommandLineOptions] describing the specified
@@ skipping 18 matching lines @@
     // OK
     return options;
   }
 
   static CommandLineOptions _parse(List<String> args) {
     var parser = new _CommandLineParser()
       ..addFlag('batch', abbr: 'b', help: 'Run in batch mode',
           defaultsTo: false, negatable: false)
       ..addOption('dart-sdk', help: 'The path to the Dart SDK')
       ..addOption('package-root', help: 'The path to the package root')
-      ..addFlag('machine-format', help: 'Specify whether errors '
-        'should be in machine format',
+      ..addFlag('machine',
+          help: 'Print errors in a format suitable for parsing',
+          defaultsTo: false, negatable: false)
+      ..addFlag('version', help: 'Print the analyzer version',
           defaultsTo: false, negatable: false)
       ..addFlag('ignore-unrecognized-flags',
           help: 'Ignore unrecognized command line flags',
           defaultsTo: false, negatable: false)
       ..addFlag('fatal-warnings', help: 'Treat non-type warnings as fatal',
           defaultsTo: false, negatable: false)
-      ..addFlag('show-package-warnings', help: 'Show warnings from package: imports',
-         defaultsTo: false, negatable: false)
+      ..addFlag('show-package-warnings',
+          help: 'Show warnings from package: imports',
+          defaultsTo: false, negatable: false)
       ..addFlag('show-sdk-warnings', help: 'Show warnings from SDK imports',
-         defaultsTo: false, negatable: false)
+          defaultsTo: false, negatable: false)
       ..addFlag('help', abbr: 'h', help: 'Display this help message',
-         defaultsTo: false, negatable: false);
+          defaultsTo: false, negatable: false);
 
     try {
       var results = parser.parse(args);
       // help requests
       if (results['help']) {
         _showUsage(parser);
         exit(0);
       }
       // batch mode and input files
       if (results['batch']) {
         if (results.rest.length != 0) {
           print('No source files expected in the batch mode.');
           _showUsage(parser);
           exit(15);
         }
+      } if (results['version']) {
+        print('$_BINARY_NAME version ${_getVersion()}');
+        exit(0);
       } else {
         if (results.rest.length == 0) {
           _showUsage(parser);
           exit(15);
         }
       }
       return new CommandLineOptions._fromArgs(results);
     } on FormatException catch (e) {
       print(e.message);
       _showUsage(parser);
       exit(15);
     }
 
   }
 
   static _showUsage(parser) {
     print('Usage: $_BINARY_NAME [options...] <libraries to analyze...>');
     print(parser.getUsage());
   }
 
+  static String _getVersion() {
+    try {
+      Path path = new Path(new Options().script);
+      Path versionPath = path.directoryPath.append('..').append('version');
+      File versionFile = new File.fromPath(versionPath);
+      
+      return versionFile.readAsStringSync().trim();
+    } catch (_) {
+      // This happens when the script is not running out of an SDK.

[scheglov, 2013/05/30 20:36:04]

Unnecessary "not"?

[devoncarew, 2013/05/30 20:42:19]

The exception is only thrown when the script is not run from an SDK. When run
from an sdk, we'll be able to find and load dart-sdk/version.

+      return "<unknown>";
+    }
+  }
 }
 
 /**
  * Commandline argument parser.
  *
  * TODO(pquitslund): when the args package supports ignoring unrecognized
  * options/flags, this class can be replaced with a simple [ArgParser] instance.
  */
 class _CommandLineParser {
 
@@ skipping 79 matching lines @@
 
   _getNextFlagIndex(args, i) {
     for ( ; i < args.length; ++i) {
       if (args[i].startsWith('--')) {
         return i;
       }
     }
     return i;
   }
 }