Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 16194010: Removes ARM mrc instruction. (Closed)

Created:
7 years, 6 months ago by zra
Modified:
7 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removes ARM mrc instruction. It is a privileged instruction and was only being used in tests running on the simulator. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=23367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -110 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M runtime/vm/constants_arm.h View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 6 months ago (2013-05-29 15:54:55 UTC) #1
regis
LGTM
7 years, 6 months ago (2013-05-29 17:17:23 UTC) #2
zra
7 years, 6 months ago (2013-05-29 21:31:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23367 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698