Issue 16157005: Fix test by correcting the smi range (assuming one tag bit and one sign bit).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16157005: Fix test by correcting the smi range (assuming one tag bit and one sign bit). (Closed)

Created:
7 years, 6 months ago by kasperl

Modified:
7 years, 6 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix test by correcting the smi range (assuming one tag bit and one sign bit). TBR'ed. R=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23573

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tests/compiler/dart2js_extra/hash_code_test.dart	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

Committed patchset #1 manually as r23573 (presubmit successful).

7 years, 6 months ago (2013-06-04 05:58:11 UTC) #2

ahe

lgtm https://codereview.chromium.org/16157005/diff/1/tests/compiler/dart2js_extra/hash_code_test.dart File tests/compiler/dart2js_extra/hash_code_test.dart (right): https://codereview.chromium.org/16157005/diff/1/tests/compiler/dart2js_extra/hash_code_test.dart#newcode30 tests/compiler/dart2js_extra/hash_code_test.dart:30: Expect.isFalse((h1 & 0xf) == (h2 & 0xf)); I ...

7 years, 6 months ago (2013-06-04 06:02:46 UTC) #3

kasperl

7 years, 6 months ago (2013-06-04 06:03:56 UTC) #4

Message was sent while issue was closed.

On 2013/06/04 06:02:46, ahe wrote:
> lgtm
> 
>
https://codereview.chromium.org/16157005/diff/1/tests/compiler/dart2js_extra/...
> File tests/compiler/dart2js_extra/hash_code_test.dart (right):
> 
>
https://codereview.chromium.org/16157005/diff/1/tests/compiler/dart2js_extra/...
> tests/compiler/dart2js_extra/hash_code_test.dart:30: Expect.isFalse((h1 & 0xf)
> == (h2 & 0xf));
> I think this test is flaky.

Yes, I agree. I'll need to fix more stuff in here.

Expand Messages | Collapse Messages