tests/compiler/dart2js_extra/hash_code_test.dart - Issue 16157005: Fix test by correcting the smi range (assuming one tag bit and one sign bit).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js_extra/hash_code_test.dart

Issue 16157005: Fix test by correcting the smi range (assuming one tag bit and one sign bit). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/compiler/dart2js_extra/hash_code_test.dart

diff --git a/tests/compiler/dart2js_extra/hash_code_test.dart b/tests/compiler/dart2js_extra/hash_code_test.dart

index 6e25fed1b31c646f23f0dff28cc6da2ff02dc90a..bf7aed523dd0f6e14d9239e8cf023769c95f25e9 100644

--- a/tests/compiler/dart2js_extra/hash_code_test.dart

+++ b/tests/compiler/dart2js_extra/hash_code_test.dart

@@ -30,8 +30,8 @@ check(value1, value2) {

Expect.isFalse((h1 & 0xf) == (h2 & 0xf));

ahe 2013/06/04 06:02:46 I think this test is flaky.

// Quality check - the values should be SMIs for efficient arithmetic.

- Expect.equals((h1 & 0x1fffffff), h1);

- Expect.equals((h2 & 0x1fffffff), h2);

+ Expect.equals((h1 & 0x3fffffff), h1);

+ Expect.equals((h2 & 0x3fffffff), h2);

}

bools() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »