Issue 16154021: Implement reflecting on uninstantiated classes.

Issue 16154021: Implement reflecting on uninstantiated classes. (Closed)

Created:
7 years, 6 months ago by ahe

Modified:
7 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, Alan Knight, ngeoffray, karlklose, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement reflecting on uninstantiated classes. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23589

Patch Set 2 : Added another test. #

Patch Set 3 : Update comment in second test. #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -22 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/compiler.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/enqueue.dart	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart	View		2 chunks	+19 lines, -9 lines	2 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
A	dart/tests/lib/mirrors/reflect_runtime_type_test.dart	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download
A	dart/tests/lib/mirrors/reflect_uninstantiated_class_test.dart	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/16154021/diff/5001/dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart File dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart (right): https://codereview.chromium.org/16154021/diff/5001/dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart#newcode469 dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:469: String toString() => 'VariableMirror(${n(qualifiedName)})'; Are you generally giving ...

7 years, 6 months ago (2013-06-04 12:45:46 UTC) #2

ahe

https://codereview.chromium.org/16154021/diff/5001/dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart File dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart (right): https://codereview.chromium.org/16154021/diff/5001/dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart#newcode469 dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:469: String toString() => 'VariableMirror(${n(qualifiedName)})'; On 2013/06/04 12:45:46, kasperl wrote: ...

7 years, 6 months ago (2013-06-04 13:07:17 UTC) #3

ahe

7 years, 6 months ago (2013-06-04 13:14:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r23589 (presubmit successful).

Expand Messages | Collapse Messages