Implement reflecting on uninstantiated classes.

dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart

Index: dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart b/dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart
index aaf30d7d4b78978f1f6ffaf676206507b0a6776d..f3e8ef70e14d384ef38d9675ec002fe5599d2444 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart
@@ -414,34 +414,40 @@ class JsVariableMirror implements VariableMirror {
   // TODO(ahe): The values in these fields are virtually untested.
   final Symbol simpleName;
   final String _jsName;
-  final bool _readOnly;
+  final bool isFinal;
+  final bool isStatic;
   final _metadataFunction;
   DeclarationMirror _owner;
   List _metadata;
 
   JsVariableMirror(this.simpleName,
                    this._jsName,
-                   this._readOnly,
+                   this.isFinal,
+                   this.isStatic,
                    this._metadataFunction);
 
   factory JsVariableMirror.from(String descriptor, metadataFunction) {
     int length = descriptor.length;
     var code = fieldCode(descriptor.codeUnitAt(length - 1));
-    if (code == 0) {
-      throw new RuntimeError('Bad field descriptor: $descriptor');
+    bool isFinal = false;
+    // code might be 0 if the accessors aren't needed, or if they are
+    // inherited.
+    // TODO(ahe): Ensure code is only 0 for inherited fields.
+    if (code != 0) {
+      bool hasGetter = (code & 3) != 0;
+      bool hasSetter = (code >> 2) != 0;
+      isFinal = !hasSetter;
+      length--;
     }
-    bool hasGetter = (code & 3) != 0;
-    bool hasSetter = (code >> 2) != 0;
     String jsName;
-    String accessorName = jsName = descriptor.substring(0, length - 1);
+    String accessorName = jsName = descriptor.substring(0, length);
     int divider = descriptor.indexOf(":");
     if (divider > 0) {
       accessorName = accessorName.substring(0, divider);
       jsName = accessorName.substring(divider + 1);
     }
-    bool readOnly = !hasSetter;
     return new JsVariableMirror(
-        s(accessorName), jsName, readOnly, metadataFunction);
+        s(accessorName), jsName, isFinal, false, metadataFunction);
   }
 
   TypeMirror get type => JsMirrorSystem._dynamicType;
@@ -458,6 +464,10 @@ class JsVariableMirror implements VariableMirror {
     return _metadata.map(reflect).toList();
   }
 
+  bool get isPrivate => n(simpleName).startsWith('_');
+
+  String toString() => 'VariableMirror(${n(qualifiedName)})';

[kasperl, 2013/06/04 12:45:46]

Are you generally giving these classes reasonable toString methods?

[ahe, 2013/06/04 13:07:17]

I plan on doing so, yes.  When I switched to symbols, I broke toString on VM
mirrors, so I plan to write a test for this at some point.

+
   static int fieldCode(int code) {
     if (code >= 60 && code <= 64) return code - 59;
     if (code >= 123 && code <= 126) return code - 117;