Issue 16097013: Make my pkg packages warning-clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16097013: Make my pkg packages warning-clean. (Closed)

Created:
7 years, 6 months ago by nweiz

Modified:
7 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make my pkg packages warning-clean. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=23620

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -9 lines)			Patch
M	pkg/http/lib/src/utils.dart	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/yaml/lib/src/yaml_map.dart	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. https://codereview.chromium.org/16097013/diff/1/pkg/yaml/lib/src/yaml_map.dart File pkg/yaml/lib/src/yaml_map.dart (right): https://codereview.chromium.org/16097013/diff/1/pkg/yaml/lib/src/yaml_map.dart#newcode39 pkg/yaml/lib/src/yaml_map.dart:39: bool get isNotEmpty => _map.isNotEmpty; Yay warnings!

7 years, 6 months ago (2013-06-04 23:17:39 UTC) #2

nweiz

7 years, 6 months ago (2013-06-04 23:34:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23620 (presubmit successful).

Expand Messages | Collapse Messages