Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart

Issue 16097013: Make my pkg packages warning-clean. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart
diff --git a/pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart b/pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart
index 7afb37921f419cc620d97871d301a85ec3e2adc5..a215a4b457f72c105a811ed0cef1a8ab0535a496 100644
--- a/pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart
+++ b/pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart
@@ -16,7 +16,7 @@ import '../../scheduled_test.dart';
import '../utils.dart';
/// A descriptor describing a single file.
-class FileDescriptor extends Descriptor implements ReadableDescriptor {
+abstract class FileDescriptor extends Descriptor implements ReadableDescriptor {
/// The contents of the file, in bytes.
final List<int> contents;
@@ -82,7 +82,7 @@ class _BinaryFileDescriptor extends FileDescriptor {
: super._(name, contents);
Future _validateNow(List<int> actualContents) {
- if (orderedIterableEquals(contents, actualContents)) return;
+ if (orderedIterableEquals(contents, actualContents)) return null;
// TODO(nweiz): show a hex dump here if the data is small enough.
throw "File '$name' didn't contain the expected binary data.";
}
@@ -93,7 +93,7 @@ class _StringFileDescriptor extends FileDescriptor {
: super._(name, encodeUtf8(contents));
Future _validateNow(List<int> actualContents) {
- if (orderedIterableEquals(contents, actualContents)) return;
+ if (orderedIterableEquals(contents, actualContents)) return null;
throw _textMismatchMessage(textContents,
new String.fromCharCodes(actualContents));
}

Powered by Google App Engine
This is Rietveld 408576698