Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 16022011: Enables optimization on MIPS (Closed)

Created:
7 years, 7 months ago by zra
Modified:
7 years, 7 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enables optimization on MIPS - Exposes double precision rather than single precision floating point registers to architecture generic code. This entails a mechanical change in the assembler to floating point instructions. - Adds slti, sltiu instructions for comparison with small immediates, and uses them in the Branch(Un)Signed* macros. - Fixes a bug in the intermediate language comparison/branching instructions caused by using subu for comparison. Now it uses two slt instructions. - Fixes register use bugs in intermediate language. - More uses of NULLREG instead of loading Object::null() R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=23190

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+576 lines, -320 lines) Patch
M runtime/tests/vm/vm.status View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 2 17 chunks +109 lines, -79 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 1 2 25 chunks +60 lines, -60 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/constants_mips.h View 1 2 1 chunk +30 lines, -4 lines 0 comments Download
M runtime/vm/disassembler_mips.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 16 chunks +106 lines, -34 lines 0 comments Download
M runtime/vm/instructions_mips.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 25 chunks +159 lines, -84 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 2 11 chunks +75 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
7 years, 7 months ago (2013-05-24 21:45:04 UTC) #1
regis
LGTM https://codereview.chromium.org/16022011/diff/7001/runtime/vm/assembler_mips.cc File runtime/vm/assembler_mips.cc (right): https://codereview.chromium.org/16022011/diff/7001/runtime/vm/assembler_mips.cc#newcode214 runtime/vm/assembler_mips.cc:214: slt(rd2, TMP1, rn); Do you always need both ...
7 years, 7 months ago (2013-05-24 22:32:59 UTC) #2
zra
Thanks! https://codereview.chromium.org/16022011/diff/7001/runtime/vm/assembler_mips.cc File runtime/vm/assembler_mips.cc (right): https://codereview.chromium.org/16022011/diff/7001/runtime/vm/assembler_mips.cc#newcode214 runtime/vm/assembler_mips.cc:214: slt(rd2, TMP1, rn); On 2013/05/24 22:32:59, regis wrote: ...
7 years, 7 months ago (2013-05-24 23:25:47 UTC) #3
zra
7 years, 7 months ago (2013-05-24 23:45:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r23190 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698