Issue 16004005: Fix generation of a bailout method when a BailoutTarget was in the middle of a loop/labeled block. …

Issue 16004005: Fix generation of a bailout method when a BailoutTarget was in the middle of a loop/labeled block. … (Closed)

Created:
7 years, 6 months ago by ngeoffray

Modified:
7 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix generation of a bailout method when a BailoutTarget was in the middle of a loop/labeled block. It confused the SSA codegen. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23337

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -7 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/bailout.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/tracer.dart	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/validate.dart	View		2 chunks	+4 lines, -2 lines	0 comments	Download
A	tests/language/inline_in_for_initializer_and_bailout_test.dart	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/16004005/diff/1/sdk/lib/_internal/compiler/implementation/ssa/tracer.dart File sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (right): https://codereview.chromium.org/16004005/diff/1/sdk/lib/_internal/compiler/implementation/ssa/tracer.dart#newcode555 sdk/lib/_internal/compiler/implementation/ssa/tracer.dart:555: String otherInput = node.inputs.length == 2 I'd suggest ...

7 years, 6 months ago (2013-05-29 10:01:20 UTC) #2

ngeoffray

Thanks Kasper. https://codereview.chromium.org/16004005/diff/1/sdk/lib/_internal/compiler/implementation/ssa/tracer.dart File sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (right): https://codereview.chromium.org/16004005/diff/1/sdk/lib/_internal/compiler/implementation/ssa/tracer.dart#newcode555 sdk/lib/_internal/compiler/implementation/ssa/tracer.dart:555: String otherInput = node.inputs.length == 2 On ...

7 years, 6 months ago (2013-05-29 10:14:16 UTC) #3

ngeoffray

7 years, 6 months ago (2013-05-29 10:14:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23337 (presubmit successful).

Expand Messages | Collapse Messages