sdk/lib/_internal/compiler/implementation/ssa/validate.dart - Issue 16004005: Fix generation of a bailout method when a BailoutTarget was in the middle of a loop/labeled block. …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/validate.dart

Issue 16004005: Fix generation of a bailout method when a BailoutTarget was in the middle of a loop/labeled block. … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/tracer.dart ('k') | tests/language/inline_in_for_initializer_and_bailout_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/validate.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/validate.dart (revision 23325)

+++ sdk/lib/_internal/compiler/implementation/ssa/validate.dart (working copy)

@@ -150,7 +150,8 @@

bool inBasicBlock = instruction.isInBasicBlock();

return everyInstruction(instruction.inputs, (input, count) {

if (inBasicBlock) {

- return countInstruction(input.usedBy, instruction) == count;

+ return input.isInBasicBlock()

+ && countInstruction(input.usedBy, instruction) == count;

} else {

return countInstruction(input.usedBy, instruction) == 0;

}

@@ -161,7 +162,8 @@

bool hasCorrectUses() {

if (!instruction.isInBasicBlock()) return true;

return everyInstruction(instruction.usedBy, (use, count) {

- return countInstruction(use.inputs, instruction) == count;

+ return use.isInBasicBlock()

+ && countInstruction(use.inputs, instruction) == count;

});

}