Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 15984010: Improve array bounds check elimination for growable lists. (Closed)

Created:
7 years, 6 months ago by Florian Schneider
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Improve array bounds check elimination for growable lists. Previously we could not eliminate bounds checks for growable lists, even though the length is not modified. This CL removes obsolete restrictions and enables elimination of checks as long as the length does not change. This restriction were there originally because the CheckArrayBounds instruction loaded the length from the array itself. Now, the length-load and the actual check are split into separate instructions. Tracking side-effects for normal loads determines can now determine if the length-load is invariant. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=23688

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -26 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 4 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 6 months ago (2013-06-06 14:35:57 UTC) #1
Vyacheslav Egorov (Google)
lGtm
7 years, 6 months ago (2013-06-06 14:38:51 UTC) #2
Florian Schneider
7 years, 6 months ago (2013-06-06 14:42:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r23688 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698