Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 15984010: Improve array bounds check elimination for growable lists. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 23667)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -129,13 +129,6 @@
}
-bool CheckArrayBoundInstr::AttributesEqual(Instruction* other) const {
- CheckArrayBoundInstr* other_check = other->AsCheckArrayBound();
- ASSERT(other_check != NULL);
- return array_type() == other_check->array_type();
-}
-
-
bool AssertAssignableInstr::AttributesEqual(Instruction* other) const {
AssertAssignableInstr* other_assert = other->AsAssertAssignable();
ASSERT(other_assert != NULL);
@@ -2347,11 +2340,6 @@
bool CheckArrayBoundInstr::IsRedundant(RangeBoundary length) {
- // Check that array has an immutable length.
- if (!IsFixedLengthArrayType(array_type())) {
- return false;
- }
-
Range* index_range = index()->definition()->range();
// Range of the index is unknown can't decide if the check is redundant.
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698