Issue 15894004: dart:io | Fix a few bugs in the Android port of dart:io.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15894004: dart:io | Fix a few bugs in the Android port of dart:io. (Closed)

Created:
7 years, 6 months ago by Bill Hesse

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Fix a few bugs in the Android port of dart:io. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23260

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -3 lines)			Patch
M	runtime/bin/directory_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file_android.cc	View	1 chunk	+8 lines, -1 line	2 comments	Download
M	runtime/bin/socket_android.cc	View	2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/15894004/diff/1/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/15894004/diff/1/runtime/bin/file_android.cc#newcode271 runtime/bin/file_android.cc:271: if (resolved == NULL) return (NULL); Remove parentheses ...

7 years, 6 months ago (2013-05-28 12:05:32 UTC) #2

Bill Hesse

https://codereview.chromium.org/15894004/diff/1/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/15894004/diff/1/runtime/bin/file_android.cc#newcode271 runtime/bin/file_android.cc:271: if (resolved == NULL) return (NULL); On 2013/05/28 12:05:32, ...

7 years, 6 months ago (2013-05-28 12:57:50 UTC) #3

Bill Hesse

7 years, 6 months ago (2013-05-28 12:58:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r23260 (presubmit successful).

Expand Messages | Collapse Messages