dart:io | Fix a few bugs in the Android port of dart:io.

runtime/bin/file_android.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_ANDROID)
 
 #include "bin/file.h"
 
 #include <errno.h>  // NOLINT
@@ skipping 247 matching lines @@
 
 
 bool File::IsAbsolutePath(const char* pathname) {
   return (pathname != NULL && pathname[0] == '/');
 }
 
 
 char* File::GetCanonicalPath(const char* pathname) {
   char* abs_path = NULL;
   if (pathname != NULL) {
+    // A null second argument to realpath crashes Android.  Fixed in Mar 2013,
+    // but not in earlier releases of Android.
+    char* resolved = reinterpret_cast<char*>(malloc(PATH_MAX));
+    if (resolved == NULL) return (NULL);

[Søren Gjesse, 2013/05/28 12:05:32]

Remove parentheses around NULL.

[Bill Hesse, 2013/05/28 12:57:50]

Done.

     do {
-      abs_path = realpath(pathname, NULL);
+      abs_path = realpath(pathname, resolved);
     } while (abs_path == NULL && errno == EINTR);
     ASSERT(abs_path == NULL || IsAbsolutePath(abs_path));
+    if (abs_path != resolved) {
+      free(resolved);
+    }
   }
   return abs_path;
 }
 
 
 char* File::GetContainingDirectory(char* pathname) {
   // Report errors for non-regular files.
   struct stat st;
   if (TEMP_FAILURE_RETRY(stat(pathname, &st)) == 0) {
     if (!S_ISREG(st.st_mode)) {
@@ skipping 62 matching lines @@
   return (file_1_info.st_ino == file_2_info.st_ino &&
           file_1_info.st_dev == file_2_info.st_dev) ?
       File::kIdentical :
       File::kDifferent;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_ANDROID)