Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 15814004: Don't report unuseful SocketIOExceptions on HttpServer. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen
Modified:
7 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Don't report unuseful SocketIOExceptions on HttpServer. 1) Don't report error if HttpResponse was closed while we were sending data. Instead, just drain/close the data sources. This matches how people expect the HttpResponse to act. This will _not_ happen for HttpClientRequest. 2) Don't report incomplete headers on HttpServer.listen. The information are not useful, as the user don't even have a chance to act on the bad headers/socket. We not just silently close the socket. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23069

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improve test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -77 lines) Patch
M sdk/lib/io/http_impl.dart View 4 chunks +26 lines, -19 lines 0 comments Download
M tests/standalone/io/http_server_early_client_close_test.dart View 2 chunks +55 lines, -55 lines 0 comments Download
M tests/standalone/io/http_server_response_test.dart View 1 7 chunks +83 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 7 months ago (2013-05-23 13:30:30 UTC) #1
Søren Gjesse
lgtm LGTM https://codereview.chromium.org/15814004/diff/1/tests/standalone/io/http_server_response_test.dart File tests/standalone/io/http_server_response_test.dart (right): https://codereview.chromium.org/15814004/diff/1/tests/standalone/io/http_server_response_test.dart#newcode141 tests/standalone/io/http_server_response_test.dart:141: write() { Maybe interleave the addStream calls ...
7 years, 7 months ago (2013-05-23 13:48:15 UTC) #2
Anders Johnsen
https://codereview.chromium.org/15814004/diff/1/tests/standalone/io/http_server_response_test.dart File tests/standalone/io/http_server_response_test.dart (right): https://codereview.chromium.org/15814004/diff/1/tests/standalone/io/http_server_response_test.dart#newcode141 tests/standalone/io/http_server_response_test.dart:141: write() { On 2013/05/23 13:48:15, Søren Gjesse wrote: > ...
7 years, 7 months ago (2013-05-23 13:54:50 UTC) #3
Anders Johnsen
7 years, 7 months ago (2013-05-23 13:55:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23069 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698