Don't report unuseful SocketIOExceptions on HttpServer.

tests/standalone/io/http_server_response_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // VMOptions=
 // VMOptions=--short_socket_read
 // VMOptions=--short_socket_write
 // VMOptions=--short_socket_read --short_socket_write
 
 import "package:expect/expect.dart";
 import "dart:async";
 import "dart:io";
 import "dart:typed_data";
 
-void testServerRequest(void handler(server, request), {int bytes}) {
+void testServerRequest(void handler(server, request),
+                       {int bytes,
+                        bool closeClient}) {
   HttpServer.bind("127.0.0.1", 0).then((server) {
     server.listen((request) {
       handler(server, request);
     });
 
     var client = new HttpClient();
     // We only close the client on either
     // - Bad response headers
     // - Response done (with optional errors in between).
     client.get("127.0.0.1", server.port, "/")
       .then((request) => request.close())
       .then((response) {
         int received = 0;
-        response.listen(
-            (data) => received += data.length,
+        var subscription;
+        subscription = response.listen(
+            (data) {
+              if (closeClient == true) {
+                subscription.cancel();
+                client.close();
+              } else {
+                received += data.length;
+              }
+            },
             onDone: () {
               if (bytes != null) Expect.equals(received, bytes);
               client.close();
             },
             onError: (error) {
               Expect.isTrue(error is HttpParserException);
             });
       })
       .catchError((error) {
          client.close();
       }, test: (e) => e is HttpParserException);
   });
 }
 
+
 void testResponseDone() {
   testServerRequest((server, request) {
     request.response.close();
     request.response.done.then((response) {
       Expect.equals(request.response, response);
       server.close();
     });
   });
 
   testServerRequest((server, request) {
     new File("__not_exitsing_file_").openRead().pipe(request.response)
         .catchError((e) {
           server.close();
         });
   });
 
   testServerRequest((server, request) {
     request.response.done.then((_) {
       server.close();
     });
     request.response.contentLength = 0;
     request.response.close();
   });
 }
 
+
 void testResponseAddStream() {
   int bytes = new File(new Options().script).lengthSync();
 
   testServerRequest((server, request) {
     request.response.addStream(new File(new Options().script).openRead())
         .then((response) {
           response.close();
           response.done.then((_) => server.close());
         });
   }, bytes: bytes);
@@ skipping 27 matching lines @@
   });
 
   testServerRequest((server, request) {
     new File("__not_exitsing_file_").openRead().pipe(request.response)
         .catchError((e) {
           server.close();
         });
   });
 }
 
+
+void testResponseAddStreamClosed() {
+  testServerRequest((server, request) {
+    request.response.addStream(new File(new Options().script).openRead())
+        .then((response) {
+          response.close();
+          response.done.then((_) => server.close());
+        });
+  }, closeClient: true);
+
+  testServerRequest((server, request) {
+    int count = 0;
+    write() {

[Søren Gjesse, 2013/05/23 13:48:15]

Maybe interleave the addStream calls with some StringSink calls.

[Anders Johnsen, 2013/05/23 13:54:50]

Done.

+      request.response.addStream(new File(new Options().script).openRead())
+          .then((response) {
+            count++;
+            if (count < 1000) {
+              write();
+            } else {
+              response.close();
+              response.done.then((_) => server.close());
+            }
+          });
+    }
+    write();
+  }, closeClient: true);
+}
+
+
+void testResponseAddClosed() {
+  testServerRequest((server, request) {
+    request.response.add(new File(new Options().script).readAsBytesSync());
+    request.response.close();
+    request.response.done.then((_) => server.close());
+  }, closeClient: true);
+
+  testServerRequest((server, request) {
+    for (int i = 0; i < 1000; i++) {
+      request.response.add(new File(new Options().script).readAsBytesSync());
+    }
+    request.response.close();
+    request.response.done.then((_) => server.close());
+  }, closeClient: true);
+
+  testServerRequest((server, request) {
+    int count = 0;
+    write() {
+      request.response.add(new File(new Options().script).readAsBytesSync());
+      Timer.run(() {
+        count++;
+        if (count < 1000) {
+          write();
+        } else {
+          request.response.close();
+          request. response.done.then((_) => server.close());
+        }
+      });
+    }
+    write();
+  }, closeClient: true);
+}
+
+
 void testBadResponseAdd() {
   testServerRequest((server, request) {
     request.response.contentLength = 0;
     request.response.add([0]);
     request.response.close();
     request.response.done.catchError((error) {
       server.close();
     }, test: (e) => e is HttpException);
   });
 
@@ skipping 12 matching lines @@
     request.response.add(new Uint8List(64 * 1024));
     request.response.add(new Uint8List(64 * 1024));
     request.response.add(new Uint8List(64 * 1024));
     request.response.close();
     request.response.done.catchError((error) {
       server.close();
     }, test: (e) => e is HttpException);
   });
 }
 
+
 void testBadResponseClose() {
   testServerRequest((server, request) {
     request.response.contentLength = 5;
     request.response.close();
     request.response.done.catchError((error) {
       server.close();
     }, test: (e) => e is HttpException);
   });
 
   testServerRequest((server, request) {
     request.response.contentLength = 5;
     request.response.add([0]);
     request.response.close();
     request.response.done.catchError((error) {
       server.close();
     }, test: (e) => e is HttpException);
   });
 }
 
+
 void main() {
   testResponseDone();
   testResponseAddStream();
+  testResponseAddStreamClosed();
+  testResponseAddClosed();
   testBadResponseAdd();
   testBadResponseClose();
 }