Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 157983005: pkg/third_party/html5lib: lots of cleanup (Closed)

Created:
6 years, 10 months ago by kevmoo
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/third_party/html5lib: lots of cleanup make a lot of things constants updated pub dependencies unused imports R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=32528

Patch Set 1 #

Patch Set 2 : bump version #

Total comments: 3

Patch Set 3 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -93 lines) Patch
M pkg/third_party/html5lib/lib/dom.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/lib/dom_parsing.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/third_party/html5lib/lib/parser.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/lib/src/constants.dart View 1 2 15 chunks +58 lines, -63 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/encoding_parser.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/lib/src/tokenizer.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/lib/src/treebuilder.dart View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/third_party/html5lib/lib/src/utils.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/pubspec.yaml View 1 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/third_party/html5lib/test/dom_compat_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/test/dom_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/test/parser_feature_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/third_party/html5lib/test/parser_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/third_party/html5lib/test/run_all.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/test/support.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/third_party/html5lib/test/tokenizer_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kevmoo
6 years, 10 months ago (2014-02-08 15:42:30 UTC) #1
Jennifer Messerly
https://codereview.chromium.org/157983005/diff/30001/pkg/third_party/html5lib/lib/src/constants.dart File pkg/third_party/html5lib/lib/src/constants.dart (right): https://codereview.chromium.org/157983005/diff/30001/pkg/third_party/html5lib/lib/src/constants.dart#newcode24 pkg/third_party/html5lib/lib/src/constants.dart:24: const Map<String, String> ERROR_MESSAGES = const { I'm a ...
6 years, 10 months ago (2014-02-10 18:59:39 UTC) #2
kevmoo
How's everything else look? https://codereview.chromium.org/157983005/diff/30001/pkg/third_party/html5lib/lib/src/constants.dart File pkg/third_party/html5lib/lib/src/constants.dart (right): https://codereview.chromium.org/157983005/diff/30001/pkg/third_party/html5lib/lib/src/constants.dart#newcode24 pkg/third_party/html5lib/lib/src/constants.dart:24: const Map<String, String> ERROR_MESSAGES = ...
6 years, 10 months ago (2014-02-10 20:20:28 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/157983005/diff/30001/pkg/third_party/html5lib/lib/src/constants.dart File pkg/third_party/html5lib/lib/src/constants.dart (right): https://codereview.chromium.org/157983005/diff/30001/pkg/third_party/html5lib/lib/src/constants.dart#newcode24 pkg/third_party/html5lib/lib/src/constants.dart:24: const Map<String, String> ERROR_MESSAGES = const { On 2014/02/10 ...
6 years, 10 months ago (2014-02-10 20:36:00 UTC) #4
kevmoo
PTAL
6 years, 10 months ago (2014-02-10 23:42:43 UTC) #5
Jennifer Messerly
LGTM! thank you!
6 years, 10 months ago (2014-02-10 23:45:09 UTC) #6
kevmoo
6 years, 10 months ago (2014-02-10 23:52:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 manually as r32528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698