pkg/third_party/html5lib: lots of cleanup

pkg/third_party/html5lib/lib/src/constants.dart

 library constants;
 
 import 'utils.dart';
-import 'token.dart';
 
 // TODO(jmesserly): fix up the const lists. For the bigger ones, we need faster
 // lookup than linear search "contains". In the Python code they were
 // frozensets.
 
 final String EOF = null;
 
 class ReparseException implements Exception {
   final String message;
   ReparseException(this.message);
   String toString() => "ReparseException: $message";
 }
 
 // TODO(jmesserly): assuming the programmatic name is not important, it would be
 // good to make these "static const" fields on an ErrorMessage class.
 /**
  * These are error messages emitted by [HtmlParser]. The values use Python style
  * string formatting, as implemented by [formatStr]. That function only supports
  * the subset of format functionality used here.
  */
-final Map<String, String> errorMessages = const {
+const Map<String, String> errorMessages = const {
   "null-character":
      "Null character in input stream, replaced with U+FFFD.",
   "invalid-codepoint":
      "Invalid codepoint in stream.",
   "incorrectly-placed-solidus":
      "Solidus (/) incorrectly placed in tag.",
   "incorrect-cr-newline-entity":
      "Incorrect CR newline entity, replaced with LF.",
   "illegal-windows-1252-entity":
      "Entity used with illegal number (windows-1252 reference).",
@@ skipping 281 matching lines @@
       case mathml: return 'math';
       case svg: return 'svg';
       case xlink: return 'xlink';
       case xml: return 'xml';
       case xmlns: return 'xmlns';
       default: throw new ArgumentError(url);
     }
   }
 }
 
-final List scopingElements = const [
+const List scopingElements = const [
   const Pair(Namespaces.html, "applet"),
   const Pair(Namespaces.html, "caption"),
   const Pair(Namespaces.html, "html"),
   const Pair(Namespaces.html, "marquee"),
   const Pair(Namespaces.html, "object"),
   const Pair(Namespaces.html, "table"),
   const Pair(Namespaces.html, "td"),
   const Pair(Namespaces.html, "th"),
   const Pair(Namespaces.mathml, "mi"),
   const Pair(Namespaces.mathml, "mo"),
   const Pair(Namespaces.mathml, "mn"),
   const Pair(Namespaces.mathml, "ms"),
   const Pair(Namespaces.mathml, "mtext"),
   const Pair(Namespaces.mathml, "annotation-xml"),
   const Pair(Namespaces.svg, "foreignObject"),
   const Pair(Namespaces.svg, "desc"),
   const Pair(Namespaces.svg, "title")
 ];
 
 
-final formattingElements = const [
+const formattingElements = const [
   const Pair(Namespaces.html, "a"),
   const Pair(Namespaces.html, "b"),
   const Pair(Namespaces.html, "big"),
   const Pair(Namespaces.html, "code"),
   const Pair(Namespaces.html, "em"),
   const Pair(Namespaces.html, "font"),
   const Pair(Namespaces.html, "i"),
   const Pair(Namespaces.html, "nobr"),
   const Pair(Namespaces.html, "s"),
   const Pair(Namespaces.html, "small"),
   const Pair(Namespaces.html, "strike"),
   const Pair(Namespaces.html, "strong"),
   const Pair(Namespaces.html, "tt"),
   const Pair(Namespaces.html, "")
 ];
 
-final specialElements = const [
+const specialElements = const [
   const Pair(Namespaces.html, "address"),
   const Pair(Namespaces.html, "applet"),
   const Pair(Namespaces.html, "area"),
   const Pair(Namespaces.html, "article"),
   const Pair(Namespaces.html, "aside"),
   const Pair(Namespaces.html, "base"),
   const Pair(Namespaces.html, "basefont"),
   const Pair(Namespaces.html, "bgsound"),
   const Pair(Namespaces.html, "blockquote"),
   const Pair(Namespaces.html, "body"),
@@ skipping 62 matching lines @@
   const Pair(Namespaces.html, "th"),
   const Pair(Namespaces.html, "thead"),
   const Pair(Namespaces.html, "title"),
   const Pair(Namespaces.html, "tr"),
   const Pair(Namespaces.html, "ul"),
   const Pair(Namespaces.html, "wbr"),
   const Pair(Namespaces.html, "xmp"),
   const Pair(Namespaces.svg, "foreignObject")
 ];
 
-final htmlIntegrationPointElements = const [
+const htmlIntegrationPointElements = const [
   const Pair(Namespaces.mathml, "annotaion-xml"),
   const Pair(Namespaces.svg, "foreignObject"),
   const Pair(Namespaces.svg, "desc"),
   const Pair(Namespaces.svg, "title")
 ];
 
-final mathmlTextIntegrationPointElements = const [
+const mathmlTextIntegrationPointElements = const [
   const Pair(Namespaces.mathml, "mi"),
   const Pair(Namespaces.mathml, "mo"),
   const Pair(Namespaces.mathml, "mn"),
   const Pair(Namespaces.mathml, "ms"),
   const Pair(Namespaces.mathml, "mtext")
 ];
 
-final spaceCharacters = " \n\r\t\u000C";
+const spaceCharacters = " \n\r\t\u000C";
 
 const int NEWLINE = 10;
 const int RETURN = 13;
 
 bool isWhitespace(String char) {
   if (char == null) return false;
   return isWhitespaceCC(char.codeUnitAt(0));
 }
 
 bool isWhitespaceCC(int charCode) {
   switch (charCode) {
     case 9:  // '\t'
     case NEWLINE: // '\n'
     case 12: // '\f'
     case RETURN: // '\r'
     case 32: // ' '
       return true;
   }
   return false;
 }
 
-final List<String> tableInsertModeElements = const [
+const List<String> tableInsertModeElements = const [
   "table",
   "tbody",
   "tfoot",
   "thead",
   "tr"
 ];
 
 // TODO(jmesserly): remove these in favor of the test functions
-final asciiLetters = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
+const asciiLetters = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
 
-final ZERO = 48;
-final LOWER_A = 97;
-final LOWER_Z = 122;
-final UPPER_A = 65;
-final UPPER_Z = 90;
+const ZERO = 48;
+const LOWER_A = 97;
+const LOWER_Z = 122;
+const UPPER_A = 65;
+const UPPER_Z = 90;
 
 bool isLetterOrDigit(String char) => isLetter(char) || isDigit(char);
 
 // Note: this is intentially ASCII only
 bool isLetter(String char) {
   if (char == null) return false;
   int cc = char.codeUnitAt(0);
   return cc >= LOWER_A && cc <= LOWER_Z || cc >= UPPER_A && cc <= UPPER_Z;
 }
 
@@ skipping 24 matching lines @@
     var c = text.codeUnitAt(i);
     if (c >= UPPER_A && c <= UPPER_Z) {
       c += LOWER_A - UPPER_A;
     }
     result[i] = c;
   }
   return new String.fromCharCodes(result);
 }
 
 // Heading elements need to be ordered
-final headingElements = const [
+const headingElements = const [
   "h1",
   "h2",
   "h3",
   "h4",
   "h5",
   "h6"
 ];
 
-final cdataElements = const ['title', 'textarea'];
+const cdataElements = const ['title', 'textarea'];
 
-final rcdataElements = const [
+const rcdataElements = const [
   'style',
   'script',
   'xmp',
   'iframe',
   'noembed',
   'noframes',
   'noscript'
 ];
 
-final Map<String, List<String>> booleanAttributes = const {
+const Map<String, List<String>> booleanAttributes = const {
   "": const ["irrelevant",],
   "style": const ["scoped",],
   "img": const ["ismap",],
   "audio": const ["autoplay","controls"],
   "video": const ["autoplay","controls"],
   "script": const ["defer", "async"],
   "details": const ["open",],
   "datagrid": const ["multiple", "disabled"],
   "command": const ["hidden", "disabled", "checked", "default"],
   "hr": const ["noshade"],
   "men": const ["autosubmit",],
   "fieldset": const ["disabled", "readonly"],
   "option": const ["disabled", "readonly", "selected"],
   "optgroup": const ["disabled", "readonly"],
   "button": const ["disabled", "autofocus"],
   "input": const ["disabled", "readonly", "required", "autofocus", "checked", "ismap"],
   "select": const ["disabled", "readonly", "autofocus", "multiple"],
   "output": const ["disabled", "readonly"],
 };
 
 // entitiesWindows1252 has to be _ordered_ and needs to have an index. It
 // therefore can't be a frozenset.
-final List<int> entitiesWindows1252 = const [
+const List<int> entitiesWindows1252 = const [
   8364,  // 0x80  0x20AC  EURO SIGN
   65533, // 0x81          UNDEFINED
   8218,  // 0x82  0x201A  SINGLE LOW-9 QUOTATION MARK
   402,   // 0x83  0x0192  LATIN SMALL LETTER F WITH HOOK
   8222,  // 0x84  0x201E  DOUBLE LOW-9 QUOTATION MARK
   8230,  // 0x85  0x2026  HORIZONTAL ELLIPSIS
   8224,  // 0x86  0x2020  DAGGER
   8225,  // 0x87  0x2021  DOUBLE DAGGER
   710,   // 0x88  0x02C6  MODIFIER LETTER CIRCUMFLEX ACCENT
   8240,  // 0x89  0x2030  PER MILLE SIGN
@@ skipping 14 matching lines @@
   732,   // 0x98  0x02DC  SMALL TILDE
   8482,  // 0x99  0x2122  TRADE MARK SIGN
   353,   // 0x9A  0x0161  LATIN SMALL LETTER S WITH CARON
   8250,  // 0x9B  0x203A  SINGLE RIGHT-POINTING ANGLE QUOTATION MARK
   339,   // 0x9C  0x0153  LATIN SMALL LIGATURE OE
   65533, // 0x9D          UNDEFINED
   382,   // 0x9E  0x017E  LATIN SMALL LETTER Z WITH CARON
   376    // 0x9F  0x0178  LATIN CAPITAL LETTER Y WITH DIAERESIS
 ];
 
-final xmlEntities = const ['lt;', 'gt;', 'amp;', 'apos;', 'quot;'];
+const xmlEntities = const ['lt;', 'gt;', 'amp;', 'apos;', 'quot;'];
 
-final Map<String, String> entities = const {
+const Map<String, String> entities = const {
   "AElig": "\xc6",
   "AElig;": "\xc6",
   "AMP": "&",
   "AMP;": "&",
   "Aacute": "\xc1",
   "Aacute;": "\xc1",
   "Abreve;": "\u0102",
   "Acirc": "\xc2",
   "Acirc;": "\xc2",
   "Acy;": "\u0410",
@@ skipping 2213 matching lines @@
   "zeta;": "\u03b6",
   "zfr;": "\u{01d537}",
   "zhcy;": "\u0436",
   "zigrarr;": "\u21dd",
   "zopf;": "\u{01d56b}",
   "zscr;": "\u{01d4cf}",
   "zwj;": "\u200d",
   "zwnj;": "\u200c",
 };
 
-Map<int, String> replacementCharacters = (() {
-  // TODO(jmesserly): fix this when Dart has literal maps with int keys.
-  var r = new Map<int, String>();
-  r[0x00] = "\uFFFD";
-  r[0x0d] = "\u000D";
-  r[0x80] = "\u20AC";
-  r[0x81] = "\u0081";
-  r[0x81] = "\u0081";
-  r[0x82] = "\u201A";
-  r[0x83] = "\u0192";
-  r[0x84] = "\u201E";
-  r[0x85] = "\u2026";
-  r[0x86] = "\u2020";
-  r[0x87] = "\u2021";
-  r[0x88] = "\u02C6";
-  r[0x89] = "\u2030";
-  r[0x8A] = "\u0160";
-  r[0x8B] = "\u2039";
-  r[0x8C] = "\u0152";
-  r[0x8D] = "\u008D";
-  r[0x8E] = "\u017D";
-  r[0x8F] = "\u008F";
-  r[0x90] = "\u0090";
-  r[0x91] = "\u2018";
-  r[0x92] = "\u2019";
-  r[0x93] = "\u201C";
-  r[0x94] = "\u201D";
-  r[0x95] = "\u2022";
-  r[0x96] = "\u2013";
-  r[0x97] = "\u2014";
-  r[0x98] = "\u02DC";
-  r[0x99] = "\u2122";
-  r[0x9A] = "\u0161";
-  r[0x9B] = "\u203A";
-  r[0x9C] = "\u0153";
-  r[0x9D] = "\u009D";
-  r[0x9E] = "\u017E";
-  r[0x9F] = "\u0178";
-  return r;
-})();
+const Map<int, String> replacementCharacters = const {
+  0x00: "\uFFFD",
+  0x0d: "\u000D",
+  0x80: "\u20AC",
+  0x81: "\u0081",
+  0x82: "\u201A",
+  0x83: "\u0192",
+  0x84: "\u201E",
+  0x85: "\u2026",
+  0x86: "\u2020",
+  0x87: "\u2021",
+  0x88: "\u02C6",
+  0x89: "\u2030",
+  0x8A: "\u0160",
+  0x8B: "\u2039",
+  0x8C: "\u0152",
+  0x8D: "\u008D",
+  0x8E: "\u017D",
+  0x8F: "\u008F",
+  0x90: "\u0090",
+  0x91: "\u2018",
+  0x92: "\u2019",
+  0x93: "\u201C",
+  0x94: "\u201D",
+  0x95: "\u2022",
+  0x96: "\u2013",
+  0x97: "\u2014",
+  0x98: "\u02DC",
+  0x99: "\u2122",
+  0x9A: "\u0161",
+  0x9B: "\u203A",
+  0x9C: "\u0153",
+  0x9D: "\u009D",
+  0x9E: "\u017E",
+  0x9F: "\u0178"
+};
 
-final Map<String, String> encodings = const {
+const Map<String, String> encodings = const {
   '437': 'cp437',
   '850': 'cp850',
   '852': 'cp852',
   '855': 'cp855',
   '857': 'cp857',
   '860': 'cp860',
   '861': 'cp861',
   '862': 'cp862',
   '863': 'cp863',
   '865': 'cp865',
@@ skipping 208 matching lines @@
   'windows1252': 'cp1252',
   'windows1253': 'cp1253',
   'windows1254': 'cp1254',
   'windows1255': 'cp1255',
   'windows1256': 'cp1256',
   'windows1257': 'cp1257',
   'windows1258': 'cp1258',
   'windows936': 'gbk',
   'x-x-big5': 'big5'
 };