Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 157813005: Check implicit super call in synthetic constructor. (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Check implicit super call in synthetic constructor. BUG= http://dartbug.com/16412 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=32616

Patch Set 1 #

Patch Set 2 : Merge some tests. #

Patch Set 3 : Separate negative tests. #

Patch Set 4 : Add more checking. #

Total comments: 5

Patch Set 5 : Address comments. #

Patch Set 6 : Was not allowed to move the code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 3 4 5 2 chunks +8 lines, -2 lines 0 comments Download
A tests/language/constructor10_test.dart View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
A tests/language/constructor11_test.dart View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
https://codereview.chromium.org/157813005/diff/70001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (left): https://codereview.chromium.org/157813005/diff/70001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#oldcode3894 sdk/lib/_internal/compiler/implementation/resolution/members.dart:3894: FunctionElement constructor = Moved these lines before the tests. ...
6 years, 10 months ago (2014-02-11 19:30:30 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/157813005/diff/70001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/157813005/diff/70001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode3897 sdk/lib/_internal/compiler/implementation/resolution/members.dart:3897: "", Can you fit the arguments on one ...
6 years, 10 months ago (2014-02-12 12:51:58 UTC) #2
floitsch
https://codereview.chromium.org/157813005/diff/70001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/157813005/diff/70001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode3897 sdk/lib/_internal/compiler/implementation/resolution/members.dart:3897: "", On 2014/02/12 12:51:58, karlklose wrote: > Can you ...
6 years, 10 months ago (2014-02-12 14:04:51 UTC) #3
floitsch
Turns out I wasn't allowed to move the code. Moved it back.
6 years, 10 months ago (2014-02-12 19:13:16 UTC) #4
floitsch
6 years, 10 months ago (2014-02-12 19:19:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #6 manually as r32616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698