Check implicit super call in synthetic constructor.

sdk/lib/_internal/compiler/implementation/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of resolution;
 
 abstract class TreeElements {
   Element get currentElement;
   Setlet<Node> get superUses;
 
@@ skipping 3861 matching lines @@
     }
 
     if (element.interfaces == null) {
       element.interfaces = resolveInterfaces(node.interfaces, node.superclass);
     } else {
       assert(invariant(element, element.hasIncompleteHierarchy));
     }
     calculateAllSupertypes(element);
 
     if (!element.hasConstructor) {
-      Element superMember =
-          element.superclass.localLookup('');
+      Element superMember = element.superclass.localLookup('');
+      FunctionElement constructor =
+          new SynthesizedConstructorElementX.forDefault(superMember, element);
+      element.setDefaultConstructor(constructor, compiler);
       if (superMember == null || !superMember.isGenerativeConstructor()) {
         DualKind kind = MessageKind.CANNOT_FIND_CONSTRUCTOR;
         Map arguments = {'constructorName': ''};
         // TODO(ahe): Why is this a compile-time error? Or if it is an error,
         // why do we bother to registerThrowNoSuchMethod below?
         compiler.reportError(node, kind.error, arguments);
         superMember = new ErroneousElementX(
             kind.error, arguments, '', element);
         compiler.backend.registerThrowNoSuchMethod(mapping);
+      } else {
+        Selector callToMatch = new Selector.call(
+            "",

[karlklose, 2014/02/12 12:51:58]

Can you fit the arguments on one line?

[floitsch, 2014/02/12 14:04:52]

Done.

+            element.getLibrary(),
+            0);
+        if (!callToMatch.applies(superMember, compiler)) {
+          MessageKind kind = MessageKind.NO_MATCHING_CONSTRUCTOR_FOR_IMPLICIT;
+          compiler.reportError(node, kind);
+        }
       }
-      FunctionElement constructor =

[floitsch, 2014/02/11 19:30:31]

Moved these lines before the tests. Could move them back if you prefer.

-          new SynthesizedConstructorElementX.forDefault(superMember, element);
-      element.setDefaultConstructor(constructor, compiler);
     }
     return element.computeType(compiler);
   }
 
   /// Resolves the mixed type for [mixinNode] and checks that the the mixin type
   /// is a valid, non-blacklisted interface type. The mixin type is returned.
   DartType checkMixinType(TypeAnnotation mixinNode) {
     DartType mixinType = resolveType(mixinNode);
     if (isBlackListed(mixinType)) {
       compiler.reportError(mixinNode,
@@ skipping 623 matching lines @@
     return finishConstructorReference(visit(expression),
                                       expression, expression);
   }
 }
 
 /// Looks up [name] in [scope] and unwraps the result.
 Element lookupInScope(Compiler compiler, Node node,
                       Scope scope, String name) {
   return Elements.unwrap(scope.lookup(name), compiler, node);
 }