Issue 15724021: Move array and string related HType from const to a field in the backend.

Issue 15724021: Move array and string related HType from const to a field in the backend. (Closed)

Created:
7 years, 6 months ago by ngeoffray

Modified:
7 years, 6 months ago

Reviewers:
Johnni Winther, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move array and string related HType from const to a field in the backend. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=23900

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+555 lines, -601 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	2 chunks	+21 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/bailout.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	50 chunks	+74 lines, -67 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	7 chunks	+10 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart	View	1	4 chunks	+11 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart	View	1	7 chunks	+11 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1	7 chunks	+34 lines, -29 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1	16 chunks	+35 lines, -40 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/tracer.dart	View	1	7 chunks	+20 lines, -16 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types.dart	View	1	10 chunks	+27 lines, -122 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart	View	1	1 chunk	+3 lines, -12 lines	0 comments	Download
M	tests/compiler/dart2js/type_combination_test.dart	View	1	24 chunks	+289 lines, -274 lines	0 comments	Download
M	tests/utils/dummy_compiler_test.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/utils/recursive_import_test.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/15724021/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right): https://codereview.chromium.org/15724021/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart#newcode2144 sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:2144: HLiteralList(inputs) : super(inputs); Add parameter for [instructionType]. https://codereview.chromium.org/15724021/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart#newcode2315 ...

7 years, 6 months ago (2013-06-12 08:58:49 UTC) #3

ngeoffray

Thanks Johnni. https://codereview.chromium.org/15724021/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right): https://codereview.chromium.org/15724021/diff/1/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart#newcode2144 sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:2144: HLiteralList(inputs) : super(inputs); On 2013/06/12 08:58:49, Johnni ...

7 years, 6 months ago (2013-06-12 09:55:50 UTC) #4

ngeoffray

7 years, 6 months ago (2013-06-12 10:20:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r23900 (presubmit successful).

Expand Messages | Collapse Messages