sdk/lib/_internal/compiler/implementation/ssa/bailout.dart - Issue 15724021: Move array and string related HType from const to a field in the backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

Issue 15724021: Move array and string related HType from const to a field in the backend. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/native_handler.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/bailout.dart (revision 23841)

+++ sdk/lib/_internal/compiler/implementation/ssa/bailout.dart (working copy)

@@ -110,7 +110,7 @@

// Primitive types that are not null are valuable. These include

// indexable arrays.

bool typeValuable(HType type) {

- return type.isPrimitive() && !type.isNull();

+ return type.isPrimitive(compiler) && !type.isNull();

}

bool get hasTypeGuards => work.guards.length != 0;

@@ -219,7 +219,8 @@

bool willThrowArgumentError(Selector selector,

HInstruction receiver,

HType speculativeType) {

- if (receiver != null && (receiver.isInteger() || receiver.isString())) {

+ if (receiver != null

+ && (receiver.isInteger() || receiver.isString(compiler))) {

return selector.isOperator()

&& selector.name != const SourceString('==')

&& (speculativeType.isNumber() && !speculativeType.isInteger());