Clean up tests that are duplicated between install and update.

Clean up tests that are duplicated between install and update.

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23160

[nweiz, 2013-05-23 20:54:57]

A couple suggestions, otherwise LGTM.

https://codereview.chromium.org/15701006/diff/1/sdk/lib/_internal/pub/test/te...
File sdk/lib/_internal/pub/test/test_pub.dart (right):

https://codereview.chromium.org/15701006/diff/1/sdk/lib/_internal/pub/test/te...
sdk/lib/_internal/pub/test/test_pub.dart:258: void runPub(String command,
{Iterable<String> args, Pattern error,
Since [command] can only be one of a finite set of supported options, make it an
enum instead of a string. You can have them have toStrings that return the
command name so you can easily pass them in to forBothPubInstallAndUpdate.

I'm not sure "runPub" is the best name for this, since it can't really run
generic pub commands. Maybe "runSimplePub" or something?

https://codereview.chromium.org/15701006/diff/1/sdk/lib/_internal/pub/test/te...
sdk/lib/_internal/pub/test/test_pub.dart:274: throw 'Unknown pub command
"$command".';
Wrap this in Exception.

https://codereview.chromium.org/15701006/diff/1/sdk/lib/_internal/pub/test/te...
sdk/lib/_internal/pub/test/test_pub.dart:282: if (warning != null) error =
warning;
We should probably document and assert that error and warning can't both be
passed. As it stands, warning will just silently clobber error if they're both
passed.

[Bob Nystrom, 2013-05-23 23:44:44]

Thanks!

https://codereview.chromium.org/15701006/diff/1/sdk/lib/_internal/pub/test/te...
File sdk/lib/_internal/pub/test/test_pub.dart (right):

https://codereview.chromium.org/15701006/diff/1/sdk/lib/_internal/pub/test/te...
sdk/lib/_internal/pub/test/test_pub.dart:258: void runPub(String command,
{Iterable<String> args, Pattern error,
On 2013/05/23 20:54:57, nweiz wrote:
> Since [command] can only be one of a finite set of supported options, make it
an
> enum instead of a string. You can have them have toStrings that return the
> command name so you can easily pass them in to forBothPubInstallAndUpdate.

Done.

> I'm not sure "runPub" is the best name for this, since it can't really run
> generic pub commands. Maybe "runSimplePub" or something?

Changed to pubCommand(). Added pubInstall() and pubUpdate() helpers for
converting later tests.

https://codereview.chromium.org/15701006/diff/1/sdk/lib/_internal/pub/test/te...
sdk/lib/_internal/pub/test/test_pub.dart:274: throw 'Unknown pub command
"$command".';
On 2013/05/23 20:54:57, nweiz wrote:
> Wrap this in Exception.

Done.

https://codereview.chromium.org/15701006/diff/1/sdk/lib/_internal/pub/test/te...
sdk/lib/_internal/pub/test/test_pub.dart:282: if (warning != null) error =
warning;
On 2013/05/23 20:54:57, nweiz wrote:
> We should probably document and assert that error and warning can't both be
> passed. As it stands, warning will just silently clobber error if they're both
> passed.

Done.

[Bob Nystrom, 2013-05-24 17:15:36]

Committed patchset #2 manually as r23160 (presubmit successful).