Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: sdk/lib/_internal/pub/test/pub_install_and_update_test.dart

Issue 15701006: Clean up tests that are duplicated between install and update. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
diff --git a/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart b/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..1cbd5a32e966af2bde8ffd555ae51eb110141ad4
--- /dev/null
+++ b/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
@@ -0,0 +1,118 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library pub_tests;
+
+import 'dart:io';
+
+import 'package:scheduled_test/scheduled_test.dart';
+
+import 'descriptor.dart' as d;
+import 'test_pub.dart';
+
+main() {
+ initConfig();
+
+ forBothPubInstallAndUpdate((command) {
+ group('requires', () {
+ integration('a pubspec', () {
+ d.dir(appPath, []).create();
+
+ pubCommand(command,
+ error: new RegExp(r'^Could not find a file named "pubspec.yaml"'));
+ });
+
+ integration('a pubspec with a "name" key', () {
+ d.dir(appPath, [
+ d.pubspec({"dependencies": {"foo": null}})
+ ]).create();
+
+ pubCommand(command, error: new RegExp(
+ r'^pubspec.yaml is missing the required "name" field '
+ r'\(e\.g\. "name: myapp"\)\.'));
+ });
+ });
+
+ integration('adds itself to the packages', () {
+ // The symlink should use the name in the pubspec, not the name of the
+ // directory.
+ d.dir(appPath, [
+ d.pubspec({"name": "myapp_name"}),
+ d.libDir('myapp_name')
+ ]).create();
+
+ pubCommand(command);
+
+ d.dir(packagesPath, [
+ d.dir("myapp_name", [
+ d.file('myapp_name.dart', 'main() => "myapp_name";')
+ ])
+ ]).validate();
+ });
+
+ integration('does not adds itself to the packages if it has no "lib" '
+ 'directory', () {
+ // The symlink should use the name in the pubspec, not the name of the
+ // directory.
+ d.dir(appPath, [
+ d.pubspec({"name": "myapp_name"}),
+ ]).create();
+
+ pubCommand(command);
+
+ d.dir(packagesPath, [
+ d.nothing("myapp_name")
+ ]).validate();
+ });
+
+ integration('does not add a package if it does not have a "lib" '
+ 'directory', () {
+ // Using a path source, but this should be true of all sources.
+ d.dir('foo', [
+ d.libPubspec('foo', '0.0.0-not.used')
+ ]).create();
+
+ d.dir(appPath, [
+ d.pubspec({"name": "myapp", "dependencies": {"foo": {"path": "../foo"}}})
+ ]).create();
+
+ pubCommand(command);
+
+ d.packagesDir({"foo": null}).validate();
+ });
+
+ integration('reports a solver failure', () {
+ // myapp depends on foo and bar which both depend on baz with mismatched
+ // descriptions.
+ d.dir('deps', [
+ d.dir('foo', [
+ d.pubspec({"name": "foo", "dependencies": {
+ "baz": {"path": "../baz1"}
+ }})
+ ]),
+ d.dir('bar', [
+ d.pubspec({"name": "bar", "dependencies": {
+ "baz": {"path": "../baz2"}
+ }})
+ ]),
+ d.dir('baz1', [
+ d.libPubspec('baz', '0.0.0')
+ ]),
+ d.dir('baz2', [
+ d.libPubspec('baz', '0.0.0')
+ ])
+ ]).create();
+
+ d.dir(appPath, [
+ d.pubspec({"name": "myapp", "dependencies": {
+ "foo": {"path": "../deps/foo"},
+ "bar": {"path": "../deps/bar"}
+ }})
+ ]).create();
+
+ pubCommand(command,
+ error: new RegExp(r"^Incompatible dependencies on 'baz':"));
+ });
+ });
+}
« no previous file with comments | « sdk/lib/_internal/pub/test/install/unknown_source_test.dart ('k') | sdk/lib/_internal/pub/test/test_pub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698