Issue 15697004: Add a proper HInvokeConstructorBody instead of mis-using HInvokeDynamicMethod.

Issue 15697004: Add a proper HInvokeConstructorBody instead of mis-using HInvokeDynamicMethod. (Closed)

Created:
7 years, 7 months ago by ngeoffray

Modified:
7 years, 7 months ago

Reviewers:
karlklose, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add a proper HInvokeConstructorBody instead of mis-using HInvokeDynamicMethod. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23013

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -44 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+3 lines, -14 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View		2 chunks	+28 lines, -26 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View		4 chunks	+12 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/tracer.dart	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/world.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. Much cleaner. https://codereview.chromium.org/15697004/diff/1/sdk/lib/_internal/compiler/implementation/world.dart File sdk/lib/_internal/compiler/implementation/world.dart (right): https://codereview.chromium.org/15697004/diff/1/sdk/lib/_internal/compiler/implementation/world.dart#newcode209 sdk/lib/_internal/compiler/implementation/world.dart:209: assert(!element.isGenerativeConstructorBody()); Add a comment that explains ...

7 years, 7 months ago (2013-05-22 12:49:15 UTC) #2

ngeoffray

Thanks Kasper. https://codereview.chromium.org/15697004/diff/1/sdk/lib/_internal/compiler/implementation/world.dart File sdk/lib/_internal/compiler/implementation/world.dart (right): https://codereview.chromium.org/15697004/diff/1/sdk/lib/_internal/compiler/implementation/world.dart#newcode209 sdk/lib/_internal/compiler/implementation/world.dart:209: assert(!element.isGenerativeConstructorBody()); On 2013/05/22 12:49:15, kasperl wrote: > ...

7 years, 7 months ago (2013-05-22 12:51:55 UTC) #3

ngeoffray

7 years, 7 months ago (2013-05-22 13:09:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r23013 (presubmit successful).

Expand Messages | Collapse Messages