Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 15697004: Add a proper HInvokeConstructorBody instead of mis-using HInvokeDynamicMethod. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 23010)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -1694,20 +1694,9 @@
bodyCallInputs.add(localsHandler.readLocal(scopeData.boxElement));
}
- // TODO(ahe): The constructor name is statically resolved. See
- // SsaCodeGenerator.visitInvokeDynamicMethod. Is there a cleaner
- // way to do this?
- SourceString name =
- new SourceString(backend.namer.getName(body.declaration));
- // TODO(kasperl): This seems fishy. We shouldn't be inventing all
- // these selectors. Maybe the resolver can do more of the work
- // for us here?
- LibraryElement library = body.getLibrary();
- Selector selector = new Selector.call(
- name, library, bodyCallInputs.length - 1);
- HInvokeDynamic invoke =
- new HInvokeDynamicMethod(selector, bodyCallInputs);
- invoke.element = body;
+ HInvokeConstructorBody invoke =
+ new HInvokeConstructorBody(body, bodyCallInputs);
+ invoke.sideEffects = compiler.world.getSideEffectsOfElement(constructor);
add(invoke);
}
closeAndGotoExit(new HReturn(newObject));
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698