Fix a bug in optimized ARM code.

Fix a bug in optimized ARM code.
Fix a bug in deoptimization (wrong stack layout assumption, worked on Intel by
chance).
Implement megamorphic instance call on ARM.
Improve line number reporting in simulator backtraces.

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23169

[zra, 2013-05-24 17:11:41]

lgtm with comments.

https://codereview.chromium.org/15692005/diff/1/runtime/vm/flow_graph_compile...
File runtime/vm/flow_graph_compiler_arm.cc (right):

https://codereview.chromium.org/15692005/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:1351: __ Drop(argument_count);
Since the arguments are already pushed on the stack before entry to this
function, a comment about the stack layout might be helpful.

https://codereview.chromium.org/15692005/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:1509: Condition
FlowGraphCompiler::FlipCondition(Condition condition) {
It looks like this is only used in intermediate_language_*.cc, Maybe we could
move it over there, and then it could sit right next to NegateCondition.

https://codereview.chromium.org/15692005/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:1528: bool
FlowGraphCompiler::EvaluateCondition(Condition condition,
I couldn't find where this function is called. It doesn't look like the versions
for the other architectures are used either.

[regis, 2013-05-24 18:52:09]

Thanks!

https://codereview.chromium.org/15692005/diff/1/runtime/vm/flow_graph_compile...
File runtime/vm/flow_graph_compiler_arm.cc (right):

https://codereview.chromium.org/15692005/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:1351: __ Drop(argument_count);
On 2013/05/24 17:11:41, zra wrote:
> Since the arguments are already pushed on the stack before entry to this
> function, a comment about the stack layout might be helpful.

Is that unexpected? The same is done for other call emitting functions. See
EmitInstanceCall above and EmitStaticCall below, for example.

https://codereview.chromium.org/15692005/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:1509: Condition
FlowGraphCompiler::FlipCondition(Condition condition) {
On 2013/05/24 17:11:41, zra wrote:
> It looks like this is only used in intermediate_language_*.cc, Maybe we could
> move it over there, and then it could sit right next to NegateCondition.

Done. There are other static functions transforming a condition. They are
usually declared close to their use, so I did the same for FlipCondition.

https://codereview.chromium.org/15692005/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_arm.cc:1528: bool
FlowGraphCompiler::EvaluateCondition(Condition condition,
On 2013/05/24 17:11:41, zra wrote:
> I couldn't find where this function is called. It doesn't look like the
versions
> for the other architectures are used either.

Done.

[regis, 2013-05-24 18:52:42]

Committed patchset #2 manually as r23169 (presubmit successful).