Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 15692005: Fix a bug in optimized ARM code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_ia32.cc
===================================================================
--- runtime/vm/flow_graph_compiler_ia32.cc (revision 23168)
+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)
@@ -1653,48 +1653,6 @@
}
-Condition FlowGraphCompiler::FlipCondition(Condition condition) {
- switch (condition) {
- case EQUAL: return EQUAL;
- case NOT_EQUAL: return NOT_EQUAL;
- case LESS: return GREATER;
- case LESS_EQUAL: return GREATER_EQUAL;
- case GREATER: return LESS;
- case GREATER_EQUAL: return LESS_EQUAL;
- case BELOW: return ABOVE;
- case BELOW_EQUAL: return ABOVE_EQUAL;
- case ABOVE: return BELOW;
- case ABOVE_EQUAL: return BELOW_EQUAL;
- default:
- UNIMPLEMENTED();
- return EQUAL;
- }
-}
-
-
-bool FlowGraphCompiler::EvaluateCondition(Condition condition,
- intptr_t left,
- intptr_t right) {
- const uintptr_t unsigned_left = static_cast<uintptr_t>(left);
- const uintptr_t unsigned_right = static_cast<uintptr_t>(right);
- switch (condition) {
- case EQUAL: return left == right;
- case NOT_EQUAL: return left != right;
- case LESS: return left < right;
- case LESS_EQUAL: return left <= right;
- case GREATER: return left > right;
- case GREATER_EQUAL: return left >= right;
- case BELOW: return unsigned_left < unsigned_right;
- case BELOW_EQUAL: return unsigned_left <= unsigned_right;
- case ABOVE: return unsigned_left > unsigned_right;
- case ABOVE_EQUAL: return unsigned_left >= unsigned_right;
- default:
- UNIMPLEMENTED();
- return false;
- }
-}
-
-
FieldAddress FlowGraphCompiler::ElementAddressForIntIndex(intptr_t cid,
intptr_t index_scale,
Register array,
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698