Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1556043006: Don't choke on dev transformers from path deps. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't choke on dev transformers from path deps. Closes #1369 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/c47da3d24ae14cf8faff59b9f123e1a43a801149

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M lib/src/pubspec.dart View 3 chunks +23 lines, -8 lines 2 comments Download
A test/transformer/gets_and_upgrades_a_package_with_a_dev_transformer_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 11 months ago (2016-01-04 22:32:37 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1556043006/diff/1/lib/src/pubspec.dart File lib/src/pubspec.dart (right): https://codereview.chromium.org/1556043006/diff/1/lib/src/pubspec.dart#newcode516 lib/src/pubspec.dart:516: var pubspecPath; Fix the indentation.
4 years, 11 months ago (2016-01-04 23:46:44 UTC) #2
nweiz
Committed patchset #1 (id:1) manually as c47da3d24ae14cf8faff59b9f123e1a43a801149 (presubmit successful).
4 years, 11 months ago (2016-01-05 01:56:58 UTC) #4
nweiz
4 years, 11 months ago (2016-01-05 01:57:13 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1556043006/diff/1/lib/src/pubspec.dart
File lib/src/pubspec.dart (right):

https://codereview.chromium.org/1556043006/diff/1/lib/src/pubspec.dart#newcod...
lib/src/pubspec.dart:516: var pubspecPath;
On 2016/01/04 23:46:44, Bob Nystrom wrote:
> Fix the indentation.

Oops, this whole change shouldn't have made it in.

Powered by Google App Engine
This is Rietveld 408576698