Don't choke on dev transformers from path deps.

lib/src/pubspec.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub.pubspec;
 
 import 'package:path/path.dart' as path;
 import 'package:pub_semver/pub_semver.dart';
 import 'package:source_span/source_span.dart';
 import 'package:yaml/yaml.dart';
@@ skipping 172 matching lines @@
           }
         }
 
         var config = _wrapSpanFormatException('transformer config', () {
           return new TransformerConfig.parse(
             libraryNode.value, libraryNode.span,
             configurationNode);
         });
 
         var package = config.id.package;
-        if (package != name &&
-            !config.id.isBuiltInTransformer &&
-            !dependencies.any((ref) => ref.name == package) &&
-            !devDependencies.any((ref) => ref.name == package) &&
-            !dependencyOverrides.any((ref) => ref.name == package)) {
+        if (package != name && !config.id.isBuiltInTransformer &&
+            !_hasDependency(package)) {
           _error('"$package" is not a dependency.',
               libraryNode.span);
         }
 
         return config;
       }).toSet();
     }).toList();
 
     return _transformers;
   }
   List<Set<TransformerConfig>> _transformers;
 
+  /// Returns whether this pubspec has any kind of dependency on [package].
+  ///
+  /// This explicitly avoids calling [_parseDependencies] because parsing dev
+  /// dependencies can fail for a hosted package's pubspec (e.g. if that package
+  /// has a relative path dev dependency).
+  bool _hasDependency(String package) {
+    return [
+      'dependencies', 'dev_dependencies', 'dependency_overrides'
+    ].any((field) {
+      var map = fields[field];
+      if (map == null) return false;
+
+      if (map is! Map) {
+        _error('"$field" field must be a map.', fields.nodes[field].span);
+      }
+
+      return map.containsKey(package);
+    });
+  }
+
   /// The environment-related metadata.
   PubspecEnvironment get environment {
     if (_environment != null) return _environment;
 
     var yaml = fields['environment'];
     if (yaml == null) {
       _environment = new PubspecEnvironment(VersionConstraint.any);
       return _environment;
     }
 
@@ skipping 269 matching lines @@
               specNode.nodes.keys.single.span);
         }
 
         descriptionNode = specNode.nodes[sourceName];
       } else {
         _error('A dependency specification must be a string or a mapping.',
             specNode.span);
       }
 
       // Let the source validate the description.
-      var ref = _wrapFormatException('description', descriptionNode.span, () {
         var pubspecPath;

[Bob Nystrom, 2016/01/04 23:46:44]

Fix the indentation.

[nweiz, 2016/01/05 01:57:13]

Oops, this whole change shouldn't have made it in.

         if (_location != null && _isFileUri(_location)) {
           pubspecPath = path.fromUri(_location);
         }
 
-        return _sources[sourceName].parseRef(name, descriptionNode.value,
+        var ref = _sources[sourceName].parseRef(name, descriptionNode.value,
             containingPath: pubspecPath);
-      });
 
       dependencies.add(ref.withConstraint(versionConstraint));
     });
 
     return dependencies;
   }
 
   /// Parses [node] to a [VersionConstraint].
   VersionConstraint _parseVersionConstraint(YamlNode node) {
     if (node.value == null) return VersionConstraint.any;
@@ skipping 75 matching lines @@
     implements ApplicationException {
   PubspecException(String message, SourceSpan span)
       : super(message, span);
 }
 
 /// Returns whether [uri] is a file URI.
 ///
 /// This is slightly more complicated than just checking if the scheme is
 /// 'file', since relative URIs also refer to the filesystem on the VM.
 bool _isFileUri(Uri uri) => uri.scheme == 'file' || uri.scheme == '';