Issue 155213002: Add a bunch of toString methods to internal Barback classes.

Issue 155213002: Add a bunch of toString methods to internal Barback classes. (Closed)

Created:
6 years, 10 months ago by nweiz

Modified:
6 years, 10 months ago

Reviewers:
Bob Nystrom, Alan Knight

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a bunch of toString methods to internal Barback classes. These will make it easier to debug barback by making it easier to inspect the current state. R=alanknight@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32304

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -15 lines)			Patch
M	pkg/barback/lib/src/asset_cascade.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/asset_node.dart	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/asset_set.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/group_runner.dart	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	pkg/barback/lib/src/phase.dart	View	6 chunks	+17 lines, -6 lines	0 comments	Download
M	pkg/barback/lib/src/phase_input.dart	View	4 chunks	+9 lines, -2 lines	2 comments	Download
M	pkg/barback/lib/src/phase_output.dart	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/transform_node.dart	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/transformer_group.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 manually as r32304 (presubmit successful).

6 years, 10 months ago (2014-02-05 00:47:10 UTC) #3

Bob Nystrom

LGTM! https://codereview.chromium.org/155213002/diff/1/pkg/barback/lib/src/phase_input.dart File pkg/barback/lib/src/phase_input.dart (right): https://codereview.chromium.org/155213002/diff/1/pkg/barback/lib/src/phase_input.dart#newcode91 pkg/barback/lib/src/phase_input.dart:91: this._location) Only indent +4.

6 years, 10 months ago (2014-02-05 20:51:13 UTC) #4

nweiz

6 years, 10 months ago (2014-02-05 21:23:24 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/155213002/diff/1/pkg/barback/lib/src/phase_in...
File pkg/barback/lib/src/phase_input.dart (right):

https://codereview.chromium.org/155213002/diff/1/pkg/barback/lib/src/phase_in...
pkg/barback/lib/src/phase_input.dart:91: this._location)
On 2014/02/05 20:51:14, Bob Nystrom wrote:
> Only indent +4.

Done.

Expand Messages | Collapse Messages