Issue 15381002: Fix a pretty bad bug of a class inheriting a patched class. The fix is

Issue 15381002: Fix a pretty bad bug of a class inheriting a patched class. The fix is (Closed)

Created:
7 years, 7 months ago by ngeoffray

Modified:
7 years, 7 months ago

Reviewers:
Johnni Winther, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a pretty bad bug of a class inheriting a patched class. The fix is 1) only use declarations when quering for subtypes or subclasses 2) allow to lookup injected members and super injected members in lookupSelector and forEachMember. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=22930

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -75 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/closure.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1 2	7 chunks	+16 lines, -13 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1 2	3 chunks	+3 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart	View	1 2	5 chunks	+9 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/full_function_set.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/world.dart	View	1 2	7 chunks	+44 lines, -20 lines	0 comments	Download
A	tests/language/issue10561_test.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

PTAL. After discussing with Johnni, I changed includeSuperMembers to includeSuperAndInjectedMembers.

7 years, 7 months ago (2013-05-21 08:51:06 UTC) #2

ngeoffray

7 years, 7 months ago (2013-05-21 11:07:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r22930 (presubmit successful).

Expand Messages | Collapse Messages