sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart - Issue 15381002: Fix a pretty bad bug of a class inheriting a patched class. The fix is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart

Issue 15381002: Fix a pretty bad bug of a class inheriting a patched class. The fix is (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/optimize.dart ('k') | sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (revision 22929)

+++ sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (working copy)

@@ -1098,7 +1098,7 @@

} else if (type.element == compiler.boolClass) {

concreteType = singletonConcreteType(baseTypes.boolBaseType);

} else {

- Set<ClassElement> subtypes = compiler.world.subtypes[type.element];

+ Set<ClassElement> subtypes = compiler.world.subtypesOf(type.element);

if (subtypes == null) continue;

concreteType = emptyConcreteType;

for (ClassElement subtype in subtypes) {

@@ -1221,7 +1221,7 @@

if (type == null) {

uninitializedFields.add(field);

}

- }, includeSuperMembers: false);

+ });

// handle initializing formals

element.functionSignature.forEachParameter((param) {