Fix string.trim (adding more runes).

Fix string.trim (adding more runes).

R=lrn@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23006

[floitsch, 2013-05-17 22:17:42]

@Lasse: should we add 0x85 to the list of whitespaces?
It's on the list of whitespaces on Wikipedia:
http://en.wikipedia.org/wiki/Whitespace_character

and JavaScript removes it. We would need to actively work against it.

[srdjan, 2013-05-20 17:09:33]

lgtm

[Lasse Reichstein Nielsen, 2013-05-21 06:20:07]

if we add U+0085 as whitespace, we should change the documentation to state that
we use the Unicode WSpace=true property, not belonging to the Zs category, as
the distinguishing test.

[Lasse Reichstein Nielsen, 2013-05-21 07:37:07]

Let's add U+0085 and use the full Unicode White_Space property:

0009..000D    ; White_Space # Cc   [5] <control-0009>..<control-000D>
0020          ; White_Space # Zs       SPACE
0085          ; White_Space # Cc       <control-0085>
00A0          ; White_Space # Zs       NO-BREAK SPACE
1680          ; White_Space # Zs       OGHAM SPACE MARK
180E          ; White_Space # Zs       MONGOLIAN VOWEL SEPARATOR
2000..200A    ; White_Space # Zs  [11] EN QUAD..HAIR SPACE
2028          ; White_Space # Zl       LINE SEPARATOR
2029          ; White_Space # Zp       PARAGRAPH SEPARATOR
202F          ; White_Space # Zs       NARROW NO-BREAK SPACE
205F          ; White_Space # Zs       MEDIUM MATHEMATICAL SPACE
3000          ; White_Space # Zs       IDEOGRAPHIC SPACE

We should still add the BOM (U+FEFF, ZERO WIDTH NO-BREAK SPACE), which is a
control character, not a whitespace.

In general, we should declare which version of Unicode we are implementing, and
use the same version everywhere. This was taken from v6.2. 
That puts dart2js at a disadvantage, since not all JS implementations have to
implement the same version of Unicode (version 3 is required, anything after
that is allowed).

[floitsch, 2013-05-21 12:10:18]

PTAL.

[floitsch, 2013-05-21 12:15:54]

Updated the CL with small bugfixes.

[Lasse Reichstein Nielsen, 2013-05-22 10:31:55]

lgtm

https://codereview.chromium.org/15348003/diff/10004/runtime/lib/string_patch....
File runtime/lib/string_patch.dart (right):

https://codereview.chromium.org/15348003/diff/10004/runtime/lib/string_patch....
runtime/lib/string_patch.dart:211: // Characters in the Zl category:
Why is the category important? Use the White_Space property instead.

[floitsch, 2013-05-22 11:09:58]

https://codereview.chromium.org/15348003/diff/10004/runtime/lib/string_patch....
File runtime/lib/string_patch.dart (right):

https://codereview.chromium.org/15348003/diff/10004/runtime/lib/string_patch....
runtime/lib/string_patch.dart:211: // Characters in the Zl category:
On 2013/05/22 10:31:55, Lasse Reichstein Nielsen wrote:
> Why is the category important? Use the White_Space property instead.

Done.

[floitsch, 2013-05-22 11:10:20]

Committed patchset #7 manually as r23006 (presubmit successful).