Fix string.trim (adding more runes).

runtime/lib/string_patch.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class String {
   /* patch */ factory String.fromCharCodes(Iterable<int> charCodes) {
     return _StringBase.createFromCharCodes(charCodes);
   }
 }
 
@@ skipping 182 matching lines @@
     if ((startIndex + 1) == endIndex) {
       return this[startIndex];
     }
     return _substringUncheckedNative(startIndex, endIndex);
   }
 
   String _substringUncheckedNative(int startIndex, int endIndex)
       native "StringBase_substringUnchecked";
 
   // Checks for one-byte whitespaces only.
-  // TODO(srdjan): Investigate if 0x85 (NEL) and 0xA0 (NBSP) are valid
-  // whitespaces for one byte strings.
   static bool _isOneByteWhitespace(int codePoint) {
     return
       (codePoint == 32) || // Space.
-      ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
+      ((9 <= codePoint) && (codePoint <= 13)) || // CR, LF, TAB, etc.
+      (codePoint == 0x85) ||  // NEL
+      (codePoint == 0xA0);  // NBSP
+  }
+
+  // Characters with Whitespace property (Unicode 6.2).
+  // 0009..000D    ; White_Space # Cc       <control-0009>..<control-000D>
+  // 0020          ; White_Space # Zs       SPACE
+  // 0085          ; White_Space # Cc       <control-0085>
+  // 00A0          ; White_Space # Zs       NO-BREAK SPACE
+  // 1680          ; White_Space # Zs       OGHAM SPACE MARK
+  // 180E          ; White_Space # Zs       MONGOLIAN VOWEL SEPARATOR
+  // 2000..200A    ; White_Space # Zs       EN QUAD..HAIR SPACE
+  // 2028          ; White_Space # Zl       LINE SEPARATOR
+  // 2029          ; White_Space # Zp       PARAGRAPH SEPARATOR
+  // 202F          ; White_Space # Zs       NARROW NO-BREAK SPACE
+  // 205F          ; White_Space # Zs       MEDIUM MATHEMATICAL SPACE
+  // 3000          ; White_Space # Zs       IDEOGRAPHIC SPACE
+  //
+  // BOM: 0xFEFF
+  static bool _isTwoByteWhitespace(int codePoint) {
+    if (codePoint < 256) return _isOneByteWhitespace(codePoint);
+    return (codePoint == 0x1680) ||
+        (codePoint == 0x180E) ||
+        ((0x2000 <= codePoint) && (codePoint <= 0x200A)) ||
+        (codePoint == 0x2028) ||
+        (codePoint == 0x2029) ||
+        (codePoint == 0x202F) ||
+        (codePoint == 0x205F) ||
+        (codePoint == 0x3000) ||
+        (codePoint == 0xFEFF);
   }
 
   String trim() {
     final int len = this.length;
     int first = 0;
     for (; first < len; first++) {
       if (!_isWhitespace(this.codeUnitAt(first))) {
         break;
       }
     }
@@ skipping 347 matching lines @@
 }
 
 
 class _TwoByteString extends _StringBase implements String {
   factory _TwoByteString._uninstantiable() {
     throw new UnsupportedError(
         "_TwoByteString can only be allocated by the VM");
   }
 
   bool _isWhitespace(int codePoint) {
-    // For now we only check for one byte white space characters.
-    return _StringBase._isOneByteWhitespace(codePoint);
+    return _StringBase._isTwoByteWhitespace(codePoint);
   }
 }
 
 
 class _ExternalOneByteString extends _StringBase implements String {
   factory _ExternalOneByteString._uninstantiable() {
     throw new UnsupportedError(
         "_ExternalOneByteString can only be allocated by the VM");
   }
 
   bool _isWhitespace(int codePoint) {
     return _StringBase._isOneByteWhitespace(codePoint);
   }
 }
 
 
 class _ExternalTwoByteString extends _StringBase implements String {
   factory _ExternalTwoByteString._uninstantiable() {
     throw new UnsupportedError(
         "_ExternalTwoByteString can only be allocated by the VM");
   }
 
   bool _isWhitespace(int codePoint) {
-    // For now we only check for one byte white space characters.
-    return _StringBase._isOneByteWhitespace(codePoint);
+    return _StringBase._isTwoByteWhitespace(codePoint);
   }
 }
 
 
 class _StringMatch implements Match {
   const _StringMatch(int this.start,
                      String this.str,
                      String this.pattern);
 
   int get end => start + pattern.length;
@@ skipping 26 matching lines @@
 class _CodeUnits extends Object with ListMixin<int>,
                                      UnmodifiableListMixin<int> {
   /** The string that this is the code units of. */
   String _string;
 
   _CodeUnits(this._string);
 
   int get length => _string.length;
   int operator[](int i) => _string.codeUnitAt(i);
 }