Improve the detection lockfile freshness.

Improve the detection lockfile freshness.

This considers the lockfile stale if the intersection of all selected
packages' SDK constraints don't match the current SDK, or if it contains
a path dependency whose own dependencies don't match the lockfile.

Closes #1091
Closes #1101

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/38b9c3ee42778ffcc74ca4f6bddb6e1a46a3f803

[Bob Nystrom, 2015-12-21 20:55:03]

https://codereview.chromium.org/1534093002/diff/1/lib/src/entrypoint.dart
File lib/src/entrypoint.dart (right):

https://codereview.chromium.org/1534093002/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:428: var hasPathDependencies = lockFileText.contains("\n
   source: path\n");
This feels really sketchy to me. We don't for certain that all lockfiles pub
reads will be ones generated by pub.

Let's talk about this when we're both in the office.

https://codereview.chromium.org/1534093002/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:480: if (id.source != 'path') return true;
Instead of checking for path specifically, how about looking at any uncached
dependency?

https://codereview.chromium.org/1534093002/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:485: });
      return cache.sources.load(id).dependencies.every(
          (dep) => overrides.contains(dep.name) || _isDependencyUpToDate(dep));

https://codereview.chromium.org/1534093002/diff/1/lib/src/lock_file.dart
File lib/src/lock_file.dart (right):

https://codereview.chromium.org/1534093002/diff/1/lib/src/lock_file.dart#newc...
lib/src/lock_file.dart:79: _validate(sdkConstraintText is String, 'The "sdk"
field must be a string.',
Long line.

https://codereview.chromium.org/1534093002/diff/1/lib/src/lock_file.dart#newc...
lib/src/lock_file.dart:143: }
Do we do this elsewhere? Maybe move it into utils?

[nweiz, 2016-01-04 23:27:29]

https://codereview.chromium.org/1534093002/diff/1/lib/src/entrypoint.dart
File lib/src/entrypoint.dart (right):

https://codereview.chromium.org/1534093002/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:428: var hasPathDependencies = lockFileText.contains("\n
   source: path\n");
On 2015/12/21 20:55:03, Bob Nystrom wrote:
> This feels really sketchy to me. We don't for certain that all lockfiles pub
> reads will be ones generated by pub.
> 
> Let's talk about this when we're both in the office.

Discussed offline.

https://codereview.chromium.org/1534093002/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:480: if (id.source != 'path') return true;
On 2015/12/21 20:55:03, Bob Nystrom wrote:
> Instead of checking for path specifically, how about looking at any uncached
> dependency?

Done.

https://codereview.chromium.org/1534093002/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:485: });
On 2015/12/21 20:55:03, Bob Nystrom wrote:
>       return cache.sources.load(id).dependencies.every(
>           (dep) => overrides.contains(dep.name) ||
_isDependencyUpToDate(dep));

Done.

https://codereview.chromium.org/1534093002/diff/1/lib/src/lock_file.dart
File lib/src/lock_file.dart (right):

https://codereview.chromium.org/1534093002/diff/1/lib/src/lock_file.dart#newc...
lib/src/lock_file.dart:79: _validate(sdkConstraintText is String, 'The "sdk"
field must be a string.',
On 2015/12/21 20:55:03, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/1534093002/diff/1/lib/src/lock_file.dart#newc...
lib/src/lock_file.dart:143: }
On 2015/12/21 20:55:03, Bob Nystrom wrote:
> Do we do this elsewhere? Maybe move it into utils?

We do something similar in pubspec.dart, but it throws a different type of
exception so we wouldn't be able to re-use code.

[nweiz, 2016-01-04 23:27:56]

Description was changed from

==========
Improve the detection lockfile freshness.

This considers the lockfile stale if the intersection of all selected
packages' SDK constraints don't match the current SDK, or if it contains
a path dependency whose own dependencies don't match the lockfile.

Closes #1091
Closes #1101

R=rnystrom@google.com
==========

to

==========
Improve the detection lockfile freshness.

This considers the lockfile stale if the intersection of all selected
packages' SDK constraints don't match the current SDK, or if it contains
a path dependency whose own dependencies don't match the lockfile.

Closes #1091
Closes #1101

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/pub/commit/38b9c3ee42778ffcc74ca4f6bddb6e1a46a3f803
==========

[nweiz, 2016-01-04 23:27:57]

Committed patchset #1 (id:1) manually as
38b9c3ee42778ffcc74ca4f6bddb6e1a46a3f803 (presubmit successful).

[Bob Nystrom, 2016-01-04 23:47:18]

lgtm