Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: test/test_pub.dart

Issue 1534093002: Improve the detection lockfile freshness. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/src/lock_file.dart ('K') | « test/must_pub_get_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/test_pub.dart
diff --git a/test/test_pub.dart b/test/test_pub.dart
index e6918d9bd08b37abe53861e3491a0d64bf0429fe..c419b4fe854a1d70d6624d44c0d8793d736838d3 100644
--- a/test/test_pub.dart
+++ b/test/test_pub.dart
@@ -219,8 +219,8 @@ void forBothPubGetAndUpgrade(void callback(RunCommand command)) {
///
/// If [exitCode] is given, expects the command to exit with that code.
// TODO(rnystrom): Clean up other tests to call this when possible.
-void pubCommand(RunCommand command,
- {Iterable<String> args, output, error, warning, int exitCode}) {
+void pubCommand(RunCommand command, {Iterable<String> args, output, error,
+ warning, int exitCode, Map<String, String> environment}) {
if (error != null && warning != null) {
throw new ArgumentError("Cannot pass both 'error' and 'warning'.");
}
@@ -236,23 +236,26 @@ void pubCommand(RunCommand command,
if (error != null) output = null;
if (warning != null) error = warning;
- schedulePub(args: allArgs, output: output, error: error, exitCode: exitCode);
+ schedulePub(args: allArgs, output: output, error: error, exitCode: exitCode,
+ environment: environment);
}
-void pubGet({Iterable<String> args, output, error, warning, int exitCode}) {
+void pubGet({Iterable<String> args, output, error, warning, int exitCode,
+ Map<String, String> environment}) {
pubCommand(RunCommand.get, args: args, output: output, error: error,
- warning: warning, exitCode: exitCode);
+ warning: warning, exitCode: exitCode, environment: environment);
}
-void pubUpgrade({Iterable<String> args, output, error, warning, int exitCode}) {
+void pubUpgrade({Iterable<String> args, output, error, warning, int exitCode,
+ Map<String, String> environment}) {
pubCommand(RunCommand.upgrade, args: args, output: output, error: error,
- warning: warning, exitCode: exitCode);
+ warning: warning, exitCode: exitCode, environment: environment);
}
void pubDowngrade({Iterable<String> args, output, error, warning,
- int exitCode}) {
+ int exitCode, Map<String, String> environment}) {
pubCommand(RunCommand.downgrade, args: args, output: output, error: error,
- warning: warning, exitCode: exitCode);
+ warning: warning, exitCode: exitCode, environment: environment);
}
/// Schedules starting the "pub [global] run" process and validates the
« lib/src/lock_file.dart ('K') | « test/must_pub_get_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698