Shard dart2js unit tests as well.

Shard dart2js unit tests as well.

R=johnniwinther@google.com, kustermann@google.com, ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22935

[Johnni Winther, 2013-05-21 10:18:01]

lgtm

[ricow1, 2013-05-21 10:26:24]

LGTM

https://codereview.chromium.org/15337003/diff/1/dart/tools/bots/compiler.py
File dart/tools/bots/compiler.py (right):

https://codereview.chromium.org/15337003/diff/1/dart/tools/bots/compiler.py#n...
dart/tools/bots/compiler.py:223: # Run the unit tests in checked mode (the VM's
checked mode).
We already do this on the checked mode bots, why not remove this? (i.e., we pass
in the --checked flag twice on the checked mode bots and once on the regular
bots)

[ahe, 2013-05-21 11:41:33]

https://codereview.chromium.org/15337003/diff/1/dart/tools/bots/compiler.py
File dart/tools/bots/compiler.py (right):

https://codereview.chromium.org/15337003/diff/1/dart/tools/bots/compiler.py#n...
dart/tools/bots/compiler.py:223: # Run the unit tests in checked mode (the VM's
checked mode).
On 2013/05/21 10:26:24, ricow1 wrote:
> We already do this on the checked mode bots, why not remove this? (i.e., we
pass
> in the --checked flag twice on the checked mode bots and once on the regular
> bots)

We are not passing the "--checked" flag twice.  All flags but the shard flags
are being removed on line 222.

These are dart2js *unit* tests, and they are not being compiled with dart2js. 
Instead they are running directly on the Dart VM, and we should not be passing
dart2js flags to the Dart VM.

[kustermann, 2013-05-21 11:44:57]

lgtm

https://codereview.chromium.org/15337003/diff/1/dart/tools/bots/compiler.py
File dart/tools/bots/compiler.py (right):

https://codereview.chromium.org/15337003/diff/1/dart/tools/bots/compiler.py#n...
dart/tools/bots/compiler.py:223: # Run the unit tests in checked mode (the VM's
checked mode).
On 2013/05/21 11:41:33, ahe wrote:
> On 2013/05/21 10:26:24, ricow1 wrote:
> > We already do this on the checked mode bots, why not remove this? (i.e., we
> pass
> > in the --checked flag twice on the checked mode bots and once on the regular
> > bots)
> 
> We are not passing the "--checked" flag twice.  All flags but the shard flags
> are being removed on line 222.
> 
> These are dart2js *unit* tests, and they are not being compiled with dart2js. 
> Instead they are running directly on the Dart VM, and we should not be passing
> dart2js flags to the Dart VM.
In addition to that, test_options.dart will throw if we pass the same flag
multiple times AFAIK.

[ahe, 2013-05-21 11:58:11]

Committed patchset #1 manually as r22935 (presubmit successful).