Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3063)

Unified Diff: dart/tools/bots/compiler.py

Issue 15337003: Shard dart2js unit tests as well. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/bots/compiler.py
diff --git a/dart/tools/bots/compiler.py b/dart/tools/bots/compiler.py
index 3cfd6e54c27a11ddfcc7de3c66076517c4e3aa84..72cf2e69a0cee959c24a6108c971b0a03ac0ffe7 100644
--- a/dart/tools/bots/compiler.py
+++ b/dart/tools/bots/compiler.py
@@ -219,9 +219,11 @@ def TestCompiler(runtime, mode, system, flags, is_buildbot, test_set):
# The dart2js compiler isn't self-hosted (yet) so we run its
# unit tests on the VM. We avoid doing this on the builders
# that run the browser tests to cut down on the cycle time.
+ unit_test_flags = [flag for flag in flags if flag.startswith('--shard')]
+ # Run the unit tests in checked mode (the VM's checked mode).
ricow1 2013/05/21 10:26:24 We already do this on the checked mode bots, why n
ahe 2013/05/21 11:41:33 We are not passing the "--checked" flag twice. Al
kustermann 2013/05/21 11:44:57 In addition to that, test_options.dart will throw
+ unit_test_flags.append('--checked')
TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js'],
- # Run the unit tests in checked mode (the VM's checked mode).
- ['--checked'])
+ unit_test_flags)
if system.startswith('win') and runtime.startswith('ie10'):
TestStep("dart2js", mode, system, 'dart2js', runtime, ['html'], flags)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698