Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 15294015: Update ENABLE_* flags (Closed)

Created:
7 years, 7 months ago by vsm
Modified:
7 years, 7 months ago
Reviewers:
Anton Muhin, antonm, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update ENABLE_* flags Bring this up to date with: http://src.chromium.org/viewvc/multivm/trunk/webkit/Source/core/features.gypi?revision=1242 Note, this does *not* change any generated code. Unused flags where removed. Added flags are precautionary. They don't affect generated code, but they are defined in a Chromium build. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=22890

Patch Set 1 #

Total comments: 4

Patch Set 2 : Trim ENABLES list and fix warnings. #

Patch Set 3 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M tools/dom/scripts/fremontcutbuilder.py View 1 2 2 chunks +14 lines, -17 lines 0 comments Download
M tools/dom/scripts/logging.conf View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
vsm
7 years, 7 months ago (2013-05-17 17:23:07 UTC) #1
Anton Muhin
https://chromiumcodereview.appspot.com/15294015/diff/1/tools/dom/scripts/fremontcutbuilder.py File tools/dom/scripts/fremontcutbuilder.py (right): https://chromiumcodereview.appspot.com/15294015/diff/1/tools/dom/scripts/fremontcutbuilder.py#newcode17 tools/dom/scripts/fremontcutbuilder.py:17: 'ENABLE_CANVAS_USES_MAILBOX', it is surprisingly too many flags coming into ...
7 years, 7 months ago (2013-05-17 18:21:03 UTC) #2
vsm
https://chromiumcodereview.appspot.com/15294015/diff/1/tools/dom/scripts/fremontcutbuilder.py File tools/dom/scripts/fremontcutbuilder.py (right): https://chromiumcodereview.appspot.com/15294015/diff/1/tools/dom/scripts/fremontcutbuilder.py#newcode17 tools/dom/scripts/fremontcutbuilder.py:17: 'ENABLE_CANVAS_USES_MAILBOX', These are ENABLE_* flags that appear in features.gyp ...
7 years, 7 months ago (2013-05-17 18:32:50 UTC) #3
Anton Muhin
https://chromiumcodereview.appspot.com/15294015/diff/1/tools/dom/scripts/fremontcutbuilder.py File tools/dom/scripts/fremontcutbuilder.py (right): https://chromiumcodereview.appspot.com/15294015/diff/1/tools/dom/scripts/fremontcutbuilder.py#newcode17 tools/dom/scripts/fremontcutbuilder.py:17: 'ENABLE_CANVAS_USES_MAILBOX', I think we should only use defines which ...
7 years, 7 months ago (2013-05-20 12:23:50 UTC) #4
vsm
https://chromiumcodereview.appspot.com/15294015/diff/1/tools/dom/scripts/fremontcutbuilder.py File tools/dom/scripts/fremontcutbuilder.py (right): https://chromiumcodereview.appspot.com/15294015/diff/1/tools/dom/scripts/fremontcutbuilder.py#newcode17 tools/dom/scripts/fremontcutbuilder.py:17: 'ENABLE_CANVAS_USES_MAILBOX', I see no warnings from those lines ...
7 years, 7 months ago (2013-05-20 14:52:52 UTC) #5
vsm
PTAL
7 years, 7 months ago (2013-05-20 15:37:00 UTC) #6
Anton Muhin
lgtm and thanks!
7 years, 7 months ago (2013-05-20 15:37:58 UTC) #7
vsm
7 years, 7 months ago (2013-05-20 15:55:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r22890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698