Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: tools/dom/scripts/fremontcutbuilder.py

Issue 15294015: Update ENABLE_* flags (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/dom/scripts/logging.conf » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/fremontcutbuilder.py
diff --git a/tools/dom/scripts/fremontcutbuilder.py b/tools/dom/scripts/fremontcutbuilder.py
index 3b172b2556762944d6869cc352de4863a71feac8..496c6c8476fbe42068e1b57c2c3ad6f90cb77279 100755
--- a/tools/dom/scripts/fremontcutbuilder.py
+++ b/tools/dom/scripts/fremontcutbuilder.py
@@ -12,40 +12,35 @@ import sys
_logger = logging.getLogger('fremontcutbuilder')
+# See:
+# http://src.chromium.org/viewvc/multivm/trunk/webkit/Source/core/features.gypi
+# for ENABLE_* flags defined in Chromium / Blink.
+# We list all ENABLE flags used in IDL in one of these two lists.
FEATURE_DISABLED = [
'ENABLE_BATTERY_STATUS',
- 'ENABLE_CSS3_CONDITIONAL_RULES',
'ENABLE_CSS_DEVICE_ADAPTATION',
'ENABLE_CUSTOM_SCHEME_HANDLER',
'ENABLE_ENCRYPTED_MEDIA_V2',
'ENABLE_MEDIA_CAPTURE', # Only enabled on Android.
'ENABLE_ORIENTATION_EVENTS', # Only enabled on Android.
- 'ENABLE_SPEECH_SYNTHESIS',
'ENABLE_WEBVTT_REGIONS',
'ENABLE_XHR_TIMEOUT',
]
FEATURE_DEFINES = [
- 'ENABLE_CALENDAR_PICKER',
- 'ENABLE_CANVAS_PROXY',
+ 'ENABLE_CALENDAR_PICKER', # Not on Android
'ENABLE_CSS_REGIONS',
- 'ENABLE_CUSTOM_ELEMENTS',
- 'ENABLE_DATALIST_ELEMENT',
- 'ENABLE_DIALOG_ELEMENT',
+ 'ENABLE_DATALIST_ELEMENT', # Not on Android
'ENABLE_ENCRYPTED_MEDIA',
- 'ENABLE_FONT_LOAD_EVENTS',
- 'ENABLE_GAMEPAD',
- 'ENABLE_INPUT_SPEECH',
- 'ENABLE_LEGACY_NOTIFICATIONS',
+ 'ENABLE_INPUT_SPEECH', # Not on Android
+ 'ENABLE_LEGACY_NOTIFICATIONS', # Not on Android
'ENABLE_MEDIA_STREAM',
- 'ENABLE_NAVIGATOR_CONTENT_UTILS',
- 'ENABLE_NOTIFICATIONS',
- 'ENABLE_PAGE_POPUP',
- 'ENABLE_SHARED_WORKERS',
+ 'ENABLE_NAVIGATOR_CONTENT_UTILS', # Not on Android
+ 'ENABLE_NOTIFICATIONS', # Not on Android
+ 'ENABLE_PAGE_POPUP', # Not on Android
'ENABLE_SVG',
'ENABLE_SVG_FONTS',
- 'ENABLE_VIDEO',
- 'ENABLE_WEB_AUDIO',
+ 'ENABLE_WEB_AUDIO', # Not on Android
'ENABLE_WEBGL',
]
@@ -111,11 +106,13 @@ def build_database(idl_files, database_dir, feature_defines=None, parallel=False
if unused_conditionals:
_logger.warning('There are some unused conditionals %s' %
sorted(unused_conditionals))
+ _logger.warning('Please update fremontcutbuilder.py')
unknown_conditionals = conditionals_met - known_conditionals
if unknown_conditionals:
_logger.warning('There are some unknown conditionals %s' %
sorted(unknown_conditionals))
+ _logger.warning('Please update fremontcutbuilder.py')
db.Save()
return db
« no previous file with comments | « no previous file | tools/dom/scripts/logging.conf » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698