Clean up the semantics of package descriptions.

Clean up the semantics of package descriptions.

This folds the distinction between "resolved" and "unresolved"
descriptions into the distinction between PackageIds and PackageRefs. In
other words, all PackageIds now have resolved descriptions and all
PackageRefs now have unresolved descriptions. This makes it easier to
track which descriptions are resolved and express resolution constraints
via the type system.

This also restricts the creation of PackageRefs and PackageIds to source
classes, which helps ensure that the description format—which is an
implementation detail—doesn't leak into surrounding code.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/a69f0c9c1f1cbc029969ae0fba9a8bc6cdedf467

[Bob Nystrom, 2015-12-17 22:57:17]

Couple of small things, but LGTM. Really nice!

https://codereview.chromium.org/1528523003/diff/1/lib/src/package.dart
File lib/src/package.dart (right):

https://codereview.chromium.org/1528523003/diff/1/lib/src/package.dart#newcod...
lib/src/package.dart:350: /// Creates a reference to package with the given
[name], [source], and
"to package" -> "to a package".

https://codereview.chromium.org/1528523003/diff/1/lib/src/source/git.dart
File lib/src/source/git.dart (right):

https://codereview.chromium.org/1528523003/diff/1/lib/src/source/git.dart#new...
lib/src/source/git.dart:207: return false;
Make this one line too.

https://codereview.chromium.org/1528523003/diff/1/lib/src/source/git.dart#new...
lib/src/source/git.dart:211: description2 is Map &&
description2.containsKey('resolved-ref')) {
These "is Map" checks aren't needed any more.

https://codereview.chromium.org/1528523003/diff/1/lib/src/source/git.dart#new...
lib/src/source/git.dart:280: } on git.GitException catch (_) {
Document what this is about.

[nweiz, 2015-12-17 23:11:15]

Code review changes

[nweiz, 2015-12-17 23:11:31]

Description was changed from

==========
Clean up the semantics of package descriptions.

This folds the distinction between "resolved" and "unresolved"
descriptions into the distinction between PackageIds and PackageRefs. In
other words, all PackageIds now have resolved descriptions and all
PackageRefs now have unresolved descriptions. This makes it easier to
track which descriptions are resolved and express resolution constraints
via the type system.

This also restricts the creation of PackageRefs and PackageIds to source
classes, which helps ensure that the description format—which is an
implementation detail—doesn't leak into surrounding code.

R=rnystrom@google.com
==========

to

==========
Clean up the semantics of package descriptions.

This folds the distinction between "resolved" and "unresolved"
descriptions into the distinction between PackageIds and PackageRefs. In
other words, all PackageIds now have resolved descriptions and all
PackageRefs now have unresolved descriptions. This makes it easier to
track which descriptions are resolved and express resolution constraints
via the type system.

This also restricts the creation of PackageRefs and PackageIds to source
classes, which helps ensure that the description format—which is an
implementation detail—doesn't leak into surrounding code.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/pub/commit/a69f0c9c1f1cbc029969ae0fba9a8bc6cdedf467
==========

[nweiz, 2015-12-17 23:11:32]

Committed patchset #2 (id:20001) manually as
a69f0c9c1f1cbc029969ae0fba9a8bc6cdedf467 (presubmit successful).