Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: lib/src/pubspec.dart

Issue 1528523003: Clean up the semantics of package descriptions. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/package.dart ('k') | lib/src/solver/backtracking_solver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/pubspec.dart
diff --git a/lib/src/pubspec.dart b/lib/src/pubspec.dart
index e53a252b2fc700c710a1100830b80eed40226ffb..db55b4d5a41be5c1edfc6d0ad22b8ddc288a2466 100644
--- a/lib/src/pubspec.dart
+++ b/lib/src/pubspec.dart
@@ -496,19 +496,17 @@ class Pubspec {
}
// Let the source validate the description.
- var description = _wrapFormatException('description',
- descriptionNode.span, () {
+ var ref = _wrapFormatException('description', descriptionNode.span, () {
var pubspecPath;
if (_location != null && _isFileUri(_location)) {
pubspecPath = path.fromUri(_location);
}
- return _sources[sourceName].parseDescription(
- pubspecPath, descriptionNode.value, fromLockFile: false);
+ return _sources[sourceName].parseRef(name, descriptionNode.value,
+ containingPath: pubspecPath);
});
- dependencies.add(new PackageDep(
- name, sourceName, versionConstraint, description));
+ dependencies.add(ref.withConstraint(versionConstraint));
});
return dependencies;
« no previous file with comments | « lib/src/package.dart ('k') | lib/src/solver/backtracking_solver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698