Issue 152543002: Fix analyzer redness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 152543002: Fix analyzer redness. (Closed)

Created:
6 years, 10 months ago by Johnni Winther

Modified:
6 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, Alan Knight, Emily Fortuna

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix analyzer redness. BUG= Committed: https://code.google.com/p/dart/source/detail?r=32235

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -6 lines)			Patch
M	pkg/intl/lib/extract_messages.dart	View	3 chunks	+5 lines, -3 lines	1 comment	Download
M	sdk/lib/_internal/dartdoc/lib/src/export_map.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language_analyzer.status	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tests/language/language_analyzer2.status	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tests/language/override_inheritance_field_test.dart	View	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

TBR https://codereview.chromium.org/152543002/diff/1/pkg/intl/lib/extract_messages.dart File pkg/intl/lib/extract_messages.dart (right): https://codereview.chromium.org/152543002/diff/1/pkg/intl/lib/extract_messages.dart#newcode1 pkg/intl/lib/extract_messages.dart:1: // Copyright (c) 2013, the Dart project authors. ...

6 years, 10 months ago (2014-02-03 08:21:27 UTC) #1

Johnni Winther

Committed patchset #1 manually as r32235 (presubmit successful).

6 years, 10 months ago (2014-02-03 08:22:57 UTC) #2

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages