Fix analyzer redness.

pkg/intl/lib/extract_messages.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file

[Johnni Winther, 2014/02/03 08:21:27]

The changes in this file fix warnings introduced in
https://codereview.chromium.org//140843002

 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This is for use in extracting messages from a Dart program
  * using the Intl.message() mechanism and writing them to a file for
  * translation. This provides only the stub of a mechanism, because it
  * doesn't define how the file should be written. It provides an
  * [IntlMessage] class that holds the extracted data and [parseString]
  * and [parseFile] methods which
@@ skipping 93 matching lines @@
    * as that will be the nearest parent of the Intl.message invocation.
    */
   FormalParameterList parameters;
   String name;
 
   /** Return true if [node] matches the pattern we expect for Intl.message() */
   bool looksLikeIntlMessage(MethodInvocation node) {
     const validNames = const ["message", "plural", "gender", "select"];
     if (!validNames.contains(node.methodName.name)) return false;
     if (!(node.target is SimpleIdentifier)) return false;
-    return node.target.token.toString() == "Intl";
+    SimpleIdentifier target = node.target;
+    return target.token.toString() == "Intl";
   }
 
   Message _expectedInstance(String type) {
     switch (type) {
       case 'message' : return new MainMessage();
       case 'plural' : return new Plural();
       case 'gender' : return new Gender();
       case 'select' : return new Select();
       default: return null;
     }
@@ skipping 271 matching lines @@
     pieces.add(messageFromMethodInvocation(node));
     super.visitMethodInvocation(node);
   }
 
   /** Return true if [node] matches the pattern for plural or gender message.*/
   bool looksLikePluralOrGender(MethodInvocation node) {
     if (!["plural", "gender", "select"].contains(node.methodName.name)) {
       return false;
     }
     if (!(node.target is SimpleIdentifier)) return false;
-    return node.target.token.toString() == "Intl";
+    SimpleIdentifier target = node.target;
+    return target.token.toString() == "Intl";
   }
 
   /**
    * Returns a String describing why the node is invalid, or null if no
    * reason is found, so it's presumed valid.
    */
   String checkValidity(MethodInvocation node) {
     // TODO(alanknight): Add reasonable validity checks.
   }
 
@@ skipping 15 matching lines @@
 
     var arguments = message.argumentsOfInterestFor(node);
     arguments.forEach((key, value) {
       try {
         var interpolation = new InterpolationVisitor(message);
         value.accept(interpolation);
         message[key] = interpolation.pieces;
       } on IntlMessageExtractionException catch (e) {
         message = null;
         var err = new StringBuffer()
-            ..writeAll(["Error ", $e, "\nProcessing <", node, ">"])
+            ..writeAll(["Error ", e, "\nProcessing <", node, ">"])
             ..write(_reportErrorLocation(node));
         print(err);
         warnings.add(err);
       }
     });
     var mainArg = node.argumentList.arguments.firstWhere(
         (each) => each is! NamedExpression);
     if (mainArg is SimpleStringLiteral) {
       message.mainArgument = mainArg.toString();
     } else {
@@ skipping 12 matching lines @@
    */
   final String message;
 
   /**
    * Creates a new exception with an optional error [message].
    */
   const IntlMessageExtractionException([this.message = ""]);
 
   String toString() => "IntlMessageExtractionException: $message";
 }